Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proteus add log entries when generating prekeys #2092

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We don't have information abot prekey generation on Proteus.

Solutions

Add log entries for generation of prekeys so we can debug what IDs are being generated and we can understand if there's a rollover (old prekeys being overwritten by new ones with the same IDs).

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Unit Test Results

   429 files     429 suites   3m 12s ⏱️
2 346 tests 2 248 ✔️ 98 💤 0

Results for commit 88866f9.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 26, 2023

Datadog Report

Branch report: chore/proteus/add-log-entries-when-generating-prekeys
Commit report: f628d3d

kalium-ios: 0 Failed, 0 New Flaky, 2131 Passed, 120 Skipped, 8m 59.04s Wall Time

@vitorhugods vitorhugods merged commit 151f59c into release/candidate Sep 26, 2023
12 checks passed
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@5efb3eb). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2092   +/-   ##
====================================================
  Coverage                     ?   58.07%           
  Complexity                   ?       24           
====================================================
  Files                        ?     1004           
  Lines                        ?    37615           
  Branches                     ?     3433           
====================================================
  Hits                         ?    21846           
  Misses                       ?    14296           
  Partials                     ?     1473           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efb3eb...88866f9. Read the comment docs.

@vitorhugods vitorhugods deleted the chore/proteus/add-log-entries-when-generating-prekeys branch September 26, 2023 11:09
tmspzz pushed a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants