chore(epic): architectural fitness functions (ACOL-123) #2133

yamilmedina · 2023-10-12T14:56:03Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Following the discussion we had in a prev. android collective, https://wearezeta.atlassian.net/browse/ACOL-123
And the first PoC, using https://github.com/TNG/ArchUnit now I'm raising a PR using the same concept but a newer library https://github.com/LemonAppDev/konsist

Causes (Optional)

Some rules will be enforced to adhere to common architecture guidelines.

Solutions

Write a few tests to validate the desired architecture state, and raise following PR's "solving" what's not compliant.

Needs release

chore: architectural fitness functions - fixed imports (ACOL-123) wire-android#2397

Testing

Test Coverage (Optional)

I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2023-10-12T15:21:05Z

Unit Test Results

  440 files -   25   440 suites - 25 25s ⏱️ - 2m 8s
2 483 tests - 109 2 364 ✔️ - 124 119 💤 +15 0 ❌ ±0

Results for commit f74b012. ± Comparison against base commit 66abde0.

♻️ This comment has been updated with latest results.

datadog-wireapp · 2023-10-12T15:27:20Z

Datadog Report

All test runs cbd0c89 🔗

❌ 2 Total Test Services: 1 Failed, 0 with New Flaky, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
`kalium-jvm`	4	0	0	2398	49	9m 38.05s	Link
`kalium-ios`	0	0	0	558	89	4m 44.2s	Link

❌ Failed Tests (4)

repositoriesShouldNotAccessFeaturePackageClasses[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'repositoriesShouldNotAccessFeaturePackageClasses' was violated (26 times). Invalid files:
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/auth/login/LoginRepository.kt (LoginRepository FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallMetadataProfile.kt (CallMetadataProfile FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallRepository.kt (CallRepository FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallingParticipantsOrder.kt (CallingParticipantsOrder FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/mapper/CallMapper.kt (CallMapper FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/E2EIClientProvider.kt (E2EIClientProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt (MLSClientProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/UserClientRepositoryProvider.kt (UserClientRepositoryProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationGroupRepository.kt (ConversationGroupRepository FileDeclaration)
 ...

useCasesShouldNotAccessDaoLayerDirectly[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCasesShouldNotAccessDaoLayerDirectly' was violated (25 times). Invalid files:
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/ProteusClientProvider.kt (ProteusClientProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/TimestampKeyRepository.kt (TimestampKeyRepository FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/asset/ScheduleNewAssetMessageUseCase.kt (ScheduleNewAssetMessageUseCase FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/backup/BackupScope.kt (BackupScope FileDeclaration)
 ...

useCasesShouldNotAccessNetworkLayerDirectly[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCasesShouldNotAccessNetworkLayerDirectly' was violated (24 times). Invalid files:
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/SessionManagerExt.kt (SessionManagerExt FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/appVersioning/ObserveIfAppUpdateRequiredUseCase.kt (ObserveIfAppUpdateRequiredUseCase FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/auth/AuthenticationScope.kt (AuthenticationScope FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/auth/sso/SSOSettingsUseCase.kt (SSOSettingsUseCase FileDeclaration)
 ...

useCaseImplementationsShouldBeInternalOrHaveInternalConstructor[jvm] - com.wire.kalium.logic.architecture.UseCaseRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCaseImplementationsShouldBeInternalOrHaveInternalConstructor' was violated (27 times). Invalid declarations:
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/AddMemberToConversationUseCase.kt:44:1 (AddMemberToConversationUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/GetConversationUnreadEventsCountUseCase.kt:38:1 (GetConversationUnreadEventsCountUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/LeaveSubconversationUseCase.kt:44:1 (LeaveSubconversationUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/LeaveConversationUseCase.kt:37:1 (LeaveConversationUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/keyingmaterials/UpdateKeyingMaterialsUseCase.kt:43:1 (UpdateKeyingMaterialsUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/RemoveMemberFromConversationUseCase.kt:44:1 (RemoveMemberFromConversationUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/ObserveArchivedUnreadConversationsCountUseCase.kt:31:1 (ObserveArchivedUnreadConversationsCountUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/selfDeletingMessages/PersistNewSelfDeletionTimerUseCase.kt:36:1 (PersistNewSelfDeletionTimerUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/session/DeregisterTokenUseCase.kt:45:1 (DeregisterTokenUseCaseImpl ClassDeclaration)
 ...

datadog-wireapp · 2023-10-23T10:15:41Z

Datadog Report

All test runs a9f8ead 🔗

❌ 2 Total Test Services: 1 Failed, 0 with New Flaky, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
`kalium-jvm`	4	0	0	2428	52	12m 18.03s	Link
`kalium-ios`	0	0	0	560	89	7m 18.08s	Link

❌ Failed Tests (4)

repositoriesShouldNotAccessFeaturePackageClasses[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'repositoriesShouldNotAccessFeaturePackageClasses' was violated (26 times). Invalid files:
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/auth/login/LoginRepository.kt (LoginRepository FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallMetadataProfile.kt (CallMetadataProfile FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallRepository.kt (CallRepository FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallingParticipantsOrder.kt (CallingParticipantsOrder FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/mapper/CallMapper.kt (CallMapper FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/E2EIClientProvider.kt (E2EIClientProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt (MLSClientProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/UserClientRepositoryProvider.kt (UserClientRepositoryProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationGroupRepository.kt (ConversationGroupRepository FileDeclaration)
 ...

useCasesShouldNotAccessDaoLayerDirectly[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCasesShouldNotAccessDaoLayerDirectly' was violated (25 times). Invalid files:
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/ProteusClientProvider.kt (ProteusClientProvider FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/TimestampKeyRepository.kt (TimestampKeyRepository FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/asset/ScheduleNewAssetMessageUseCase.kt (ScheduleNewAssetMessageUseCase FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/backup/BackupScope.kt (BackupScope FileDeclaration)
 ...

useCasesShouldNotAccessNetworkLayerDirectly[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCasesShouldNotAccessNetworkLayerDirectly' was violated (24 times). Invalid files:
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/SessionManagerExt.kt (SessionManagerExt FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/appVersioning/ObserveIfAppUpdateRequiredUseCase.kt (ObserveIfAppUpdateRequiredUseCase FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/auth/AuthenticationScope.kt (AuthenticationScope FileDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/auth/sso/SSOSettingsUseCase.kt (SSOSettingsUseCase FileDeclaration)
 ...

useCaseImplementationsShouldBeInternalOrHaveInternalConstructor[jvm] - com.wire.kalium.logic.architecture.UseCaseRulesTest - Details

Expand for error

 com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCaseImplementationsShouldBeInternalOrHaveInternalConstructor' was violated (27 times). Invalid declarations:
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/ObserveFileSharingStatusUseCase.kt:38:1 (ObserveFileSharingStatusUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UpdateSupportedProtocolsAndResolveOneOnOnesUseCase.kt:39:1 (UpdateSupportedProtocolsAndResolveOneOnOnesUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/MarkSelfDeletionStatusAsNotifiedUseCase.kt:30:1 (MarkSelfDeletionStatusAsNotifiedUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/IsFileSharingEnabledUseCase.kt:34:1 (IsFileSharingEnabledUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/call/usecase/EndCallUseCase.kt:43:1 (EndCallUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/call/usecase/UnMuteCallUseCase.kt:35:1 (UnMuteCallUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/call/usecase/EndCallOnConversationChangeUseCase.kt:20:1 (EndCallOnConversationChangeUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/asset/UpdateAssetMessageDownloadStatusUseCase.kt:44:1 (UpdateAssetMessageDownloadStatusUseCaseImpl ClassDeclaration)
 /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/selfDeletingMessages/PersistNewSelfDeletionTimerUseCase.kt:36:1 (PersistNewSelfDeletionTimerUseCaseImpl ClassDeclaration)
 ...

…bility pt1. (ACOL-123) (#2152) * chore: fix visibility of use cases, implementations must be internal to create instances * chore: fix detekt

datadog-wireapp · 2023-11-02T21:08:27Z

Datadog Report

All test runs 153f471 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
`kalium-ios`	0	0	0	2364	119	12m 44.09s	Link
`kalium-jvm`	0	0	0	2496	104	11m 49.01s	Link

…ess pt2. (ACOL-123) (#2187) * fix: broken inversed layer rule * fix: broken inversed layer rule * fix: test adj * Revert "fix: broken inversed layer rule" This reverts commit 2153cea. * fix: test adj * fix: auth dto in wrong package * fix: session establisher dto in wrong package * fix: session establisher dto in wrong package * fix: message releated dtos in wrong package * chore: architectural fitness functions - inverted layer access calling pt3. (ACOL-123) (#2188) * fix: calling releated dtos in wrong package * fix: calling references with internal usecases * fix: calling references with internal usecases * chore: architectural fitness functions - inverted layer access msg and conversations pt4. (ACOL-123) (#2190) * fix: messages and conversation references with internal usecases * fix: messages and conversation references with internal usecases * fix: messages and conversation references with internal usecases

…3) (#2196) * chore: ignore suppresed baseline of rule * chore: ignore suppresed baseline of rule * chore: ignore suppresed baseline of rule * fix: dependency resolutino * fix: dependency resolution

codecov-commenter · 2023-11-07T09:44:06Z

Codecov Report

Merging #2133 (f74b012) into develop (66abde0) will increase coverage by 0.00%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##             develop    #2133   +/-   ##
==========================================
  Coverage      57.96%   57.96%           
  Complexity        21       21           
==========================================
  Files           1065     1065           
  Lines          40502    40505    +3     
  Branches        3743     3744    +1     
==========================================
+ Hits           23475    23478    +3     
+ Misses         15413    15412    -1     
- Partials        1614     1615    +1

Files	Coverage Δ
...lium/logic/feature/call/scenario/OnAnsweredCall.kt	`0.00% <ø> (ø)`
.../kalium/logic/feature/call/scenario/OnCloseCall.kt	`81.57% <ø> (ø)`
...m/logic/feature/call/scenario/OnEstablishedCall.kt	`0.00% <ø> (ø)`
...alium/logic/feature/call/scenario/OnHttpRequest.kt	`73.07% <ø> (ø)`
...lium/logic/feature/call/scenario/OnIncomingCall.kt	`0.00% <ø> (ø)`
...re/kalium/logic/feature/call/scenario/OnSendOTR.kt	`71.79% <ø> (ø)`
...kalium/logic/configuration/UserConfigRepository.kt	`54.47% <ø> (ø)`
...lin/com/wire/kalium/logic/data/auth/AuthSession.kt	`76.19% <ø> (ø)`
...re/kalium/logic/data/auth/login/LoginRepository.kt	`95.00% <ø> (ø)`
...ain/kotlin/com/wire/kalium/logic/data/call/Call.kt	`100.00% <ø> (ø)`
... and 143 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66abde0...f74b012. Read the comment docs.

ohassine

✨🧹✨

* chore: introduce architecture fitness functions * chore: introduce architecture fitness functions * chore: introduce architecture fitness functions * chore: introduce architecture fitness functions * chore: architectural fitness functions - use case implementation visibility pt1. (ACOL-123) (#2152) * chore: fix visibility of use cases, implementations must be internal to create instances * chore: fix detekt * fix: broken use case rule * fix: broken use case rule * chore: architectural fitness functions - misc dtos inverted layer access pt2. (ACOL-123) (#2187) * fix: broken inversed layer rule * fix: broken inversed layer rule * fix: test adj * Revert "fix: broken inversed layer rule" This reverts commit 2153cea. * fix: test adj * fix: auth dto in wrong package * fix: session establisher dto in wrong package * fix: session establisher dto in wrong package * fix: message releated dtos in wrong package * chore: architectural fitness functions - inverted layer access calling pt3. (ACOL-123) (#2188) * fix: calling releated dtos in wrong package * fix: calling references with internal usecases * fix: calling references with internal usecases * chore: architectural fitness functions - inverted layer access msg and conversations pt4. (ACOL-123) (#2190) * fix: messages and conversation references with internal usecases * fix: messages and conversation references with internal usecases * fix: messages and conversation references with internal usecases * chore: architectural fitness functions - baseline final pt5. (ACOL-123) (#2196) * chore: ignore suppresed baseline of rule * chore: ignore suppresed baseline of rule * chore: ignore suppresed baseline of rule * fix: dependency resolutino * fix: dependency resolution

yamilmedina added 3 commits October 12, 2023 15:59

chore: introduce architecture fitness functions

7fff3c7

chore: introduce architecture fitness functions

57f2390

chore: introduce architecture fitness functions

7a3d698

github-actions bot assigned yamilmedina Oct 12, 2023

github-actions bot added 🚨 Potential breaking changes type: chore 🧹 👕 size: M labels Oct 12, 2023

yamilmedina changed the title ~~chore: arch fitness functions konsist (ACOL-123)~~ chore: architectural fitness function konsist (ACOL-123) Oct 12, 2023

yamilmedina marked this pull request as draft October 12, 2023 14:57

chore: introduce architecture fitness functions

9185b6c

yamilmedina changed the title ~~chore: architectural fitness function konsist (ACOL-123)~~ chore: architectural fitness function (ACOL-123) Oct 12, 2023

Merge branch 'develop' into chore/arch-fitness-functions

ff7ea45

yamilmedina changed the title ~~chore: architectural fitness function (ACOL-123)~~ chore: architectural fitness functions (ACOL-123) Oct 18, 2023

yamilmedina mentioned this pull request Oct 18, 2023

chore: architectural fitness functions - use case implementation visibility pt1. (ACOL-123) #2152

Merged

7 tasks

Merge branch 'develop' into chore/arch-fitness-functions

059ca6d

yamilmedina added 3 commits October 24, 2023 06:47

Merge branch 'develop' into chore/arch-fitness-functions

4322ff0

chore: architectural fitness functions - use case implementation visi…

df987f3

…bility pt1. (ACOL-123) (#2152) * chore: fix visibility of use cases, implementations must be internal to create instances * chore: fix detekt

Merge branch 'develop' into chore/arch-fitness-functions

1eb55e2

yamilmedina added 3 commits November 3, 2023 06:26

Merge branch 'develop' into chore/arch-fitness-functions

045af75

fix: broken use case rule

3f3a8af

fix: broken use case rule

a9ea37b

yamilmedina mentioned this pull request Nov 3, 2023

chore: architectural fitness functions - misc dtos inverted layer access pt2. (ACOL-123) #2187

Merged

7 tasks

Merge branch 'develop' into chore/arch-fitness-functions

e27a1cc

yamilmedina changed the title ~~chore: architectural fitness functions (ACOL-123)~~ chore(epic): architectural fitness functions (ACOL-123) Nov 3, 2023

yamilmedina added 2 commits November 6, 2023 14:12

Merge branch 'develop' into chore/arch-fitness-functions

912194f

github-actions bot added 👕 size: XL and removed 👕 size: M labels Nov 6, 2023

yamilmedina requested review from a team, gongracr, borichellow, MohamadJaara, vitorhugods, saleniuk, Garzas and alexandreferris and removed request for a team November 6, 2023 13:12

yamilmedina marked this pull request as ready for review November 6, 2023 13:13

yamilmedina added 2 commits November 7, 2023 06:14

chore: architectural fitness functions - baseline final pt5. (ACOL-12…

13b3a54

…3) (#2196) * chore: ignore suppresed baseline of rule * chore: ignore suppresed baseline of rule * chore: ignore suppresed baseline of rule * fix: dependency resolutino * fix: dependency resolution

Merge branch 'develop' into chore/arch-fitness-functions

f74b012

yamilmedina removed the request for review from gongracr November 7, 2023 09:26

yamilmedina enabled auto-merge November 7, 2023 09:32

yamilmedina requested a review from ohassine November 7, 2023 09:32

yamilmedina mentioned this pull request Nov 7, 2023

chore: architectural fitness functions - fixed imports (ACOL-123) wireapp/wire-android#2397

Merged

6 tasks

Garzas approved these changes Nov 7, 2023

View reviewed changes

ohassine approved these changes Nov 7, 2023

View reviewed changes

yamilmedina added this pull request to the merge queue Nov 7, 2023

Merged via the queue into develop with commit 9a38a90 Nov 7, 2023
17 checks passed

yamilmedina deleted the chore/arch-fitness-functions branch November 7, 2023 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(epic): architectural fitness functions (ACOL-123) #2133

chore(epic): architectural fitness functions (ACOL-123) #2133

yamilmedina commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

datadog-wireapp bot commented Oct 12, 2023 •

edited

Loading

datadog-wireapp bot commented Oct 23, 2023 •

edited

Loading

datadog-wireapp bot commented Nov 2, 2023 •

edited

Loading

codecov-commenter commented Nov 7, 2023

ohassine left a comment

chore(epic): architectural fitness functions (ACOL-123) #2133

chore(epic): architectural fitness functions (ACOL-123) #2133

Conversation

yamilmedina commented Oct 12, 2023 • edited Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Needs release

Testing

Test Coverage (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Oct 12, 2023 • edited Loading

Unit Test Results

datadog-wireapp bot commented Oct 12, 2023 • edited Loading

Datadog Report

❌ Failed Tests (4)

datadog-wireapp bot commented Oct 23, 2023 • edited Loading

Datadog Report

❌ Failed Tests (4)

datadog-wireapp bot commented Nov 2, 2023 • edited Loading

Datadog Report

codecov-commenter commented Nov 7, 2023

Codecov Report

ohassine left a comment

Choose a reason for hiding this comment

yamilmedina commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

datadog-wireapp bot commented Oct 12, 2023 •

edited

Loading

datadog-wireapp bot commented Oct 23, 2023 •

edited

Loading

datadog-wireapp bot commented Nov 2, 2023 •

edited

Loading