Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: architectural fitness functions - fixed imports (ACOL-123) #2397

Merged
merged 16 commits into from
Nov 8, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 7, 2023

TopicACOL-123 Android meets backend best practices


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updates references modified by core work done in kalium refactor to test architecture and fix no compliance.

Causes (Optional)

Some references were moved from location or visibility changed.

Solutions

Fix imports and references to classes on kalium by


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Test Results

678 tests  ±0   678 ✔️ ±0   6m 45s ⏱️ - 3m 18s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit 353b674. ± Comparison against base commit 1e614ca.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina enabled auto-merge November 7, 2023 11:52
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2397 (353b674) into develop (1e614ca) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             develop    #2397   +/-   ##
==========================================
  Coverage      41.47%   41.47%           
  Complexity      1081     1081           
==========================================
  Files            344      344           
  Lines          12389    12389           
  Branches        1629     1629           
==========================================
  Hits            5138     5138           
  Misses          6767     6767           
  Partials         484      484           
Files Coverage Δ
...n/com/wire/android/feature/AccountSwitchUseCase.kt 64.93% <ø> (ø)
.../migration/feature/MigrateActiveAccountsUseCase.kt 1.66% <ø> (ø)
...re/android/notification/CallNotificationManager.kt 30.39% <ø> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 71.65% <ø> (ø)
...roid/ui/authentication/welcome/WelcomeViewModel.kt 0.00% <ø> (ø)
...in/kotlin/com/wire/android/ui/calling/CallState.kt 100.00% <ø> (ø)
.../wire/android/ui/calling/SharedCallingViewModel.kt 66.46% <ø> (ø)
.../ui/home/conversations/MessageComposerViewModel.kt 80.81% <ø> (ø)
.../ui/home/conversations/MessageComposerViewState.kt 83.33% <ø> (ø)
...s/details/options/GroupConversationOptionsState.kt 90.47% <ø> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e614ca...353b674. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1678 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Nov 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
313fa794cf98ac3812f33d75ccd7ac76f469a6b3 33129c1afa4b511ba3cc00325778649c351bd503

Is this intentional?

@yamilmedina yamilmedina enabled auto-merge November 8, 2023 09:57
Copy link
Contributor

github-actions bot commented Nov 8, 2023

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
313fa794cf98ac3812f33d75ccd7ac76f469a6b3 19b37238cf4890583da7c836eeaf45cea6f4aba1

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 1690 failed.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
313fa794cf98ac3812f33d75ccd7ac76f469a6b3 603c0a38cbee6df848fe4455a507cc49db78a609

Is this intentional?

@yamilmedina yamilmedina added this pull request to the merge queue Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit f666c81 Nov 8, 2023
12 checks passed
@yamilmedina yamilmedina deleted the fix/dependecies-arch-hardening-tests branch November 8, 2023 12:09
@AndroidBob
Copy link
Collaborator

Build 1693 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants