Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mls-e2ei): adopt remaining E2EI functions (WPB-2928) #2156

Merged
merged 13 commits into from
Oct 23, 2023

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adapting remaining functions for E2EI from CoreCrypto.

Testing

Test Coverage (Optional)

WIP

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani marked this pull request as ready for review October 19, 2023 11:28
@mchenani mchenani changed the title feat(mls-e2ei): adapt remaining E2EI functions (WPB-2928) feat(mls-e2ei): adopt remaining E2EI functions (WPB-2928) Oct 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Unit Test Results

   458 files  ±0     458 suites  ±0   2m 16s ⏱️ - 1m 8s
2 553 tests +1  2 449 ✔️ +1  104 💤 ±0  0 ±0 

Results for commit 3c639e9. ± Comparison against base commit 3df8be3.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 20, 2023

Datadog Report

All test runs eb51716 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1793 55 4m 15.08s Link
kalium-jvm 0 0 0 2449 104 11m 20.01s Link

@mchenani mchenani enabled auto-merge October 23, 2023 08:35
@mchenani mchenani added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@mchenani mchenani enabled auto-merge October 23, 2023 11:37
@mchenani mchenani added this pull request to the merge queue Oct 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2156 (3c639e9) into develop (3df8be3) will increase coverage by 0.00%.
The diff coverage is 72.00%.

@@            Coverage Diff             @@
##             develop    #2156   +/-   ##
==========================================
  Coverage      57.81%   57.81%           
  Complexity        21       21           
==========================================
  Files           1059     1059           
  Lines          40166    40183   +17     
  Branches        3720     3721    +1     
==========================================
+ Hits           23223    23233   +10     
- Misses         15336    15342    +6     
- Partials        1607     1608    +1     
Files Coverage Δ
...lium/logic/data/conversation/ConversationMapper.kt 58.58% <100.00%> (+0.57%) ⬆️
...gic/data/conversation/MLSConversationRepository.kt 84.42% <100.00%> (-0.15%) ⬇️
...monMain/kotlin/com/wire/kalium/cryptography/IDs.kt 74.35% <76.92%> (+5.39%) ⬆️
...n/kotlin/com/wire/kalium/cryptography/MLSClient.kt 81.48% <33.33%> (-13.98%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df8be3...3c639e9. Read the comment docs.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@mchenani mchenani added this pull request to the merge queue Oct 23, 2023
@mchenani mchenani removed this pull request from the merge queue due to a manual request Oct 23, 2023
@mchenani mchenani added this pull request to the merge queue Oct 23, 2023
Merged via the queue into develop with commit 97ad1de Oct 23, 2023
15 checks passed
@mchenani mchenani deleted the feat/e2ei/adapt-remaining-e2ei-fucntions branch October 23, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants