Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applock): team app lock dialog displayed when changing timeout #2232

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On Client side, team app lock dialog is displayed when changing timeout from team console.

Causes (Optional)

Wrong logic for setting isStatusChanged value

Solutions

Use last saved value of isStatusChanged, if the status is the same as current

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Unit Test Results

   342 files   - 130     342 suites   - 130   10s ⏱️ - 2m 10s
1 851 tests  - 780  1 821 ✔️  - 706  30 💤  - 74  0 ±0 

Results for commit 1912685. ± Comparison against base commit b29d505.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

All test runs 172cb8c 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1821 30 11s Link
kalium-jvm 0 0 0 2526 104 7m 21.04s Link

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 16, 2023
Merged via the queue into develop with commit 3a9836b Nov 16, 2023
16 checks passed
@MohamadJaara MohamadJaara deleted the team_change_app_lock branch November 16, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants