-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: configure and allow cipher suites (WPB-5448) #2233
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2233 +/- ##
=============================================
- Coverage 58.00% 58.00% -0.01%
Complexity 21 21
=============================================
Files 1075 1075
Lines 40807 40807
Branches 3777 3777
=============================================
- Hits 23671 23669 -2
- Misses 15517 15518 +1
- Partials 1619 1620 +1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
.cipherSuites( | ||
TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, | ||
TLS_AES_128_GCM_SHA256, | ||
TLS_AES_256_GCM_SHA384 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: the same okHttp is reused not only to connect to wire server but also to other servers (fetch custom e.g. server config), do we want to limit this change to only okhttp instances that are used to connect to wire servers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the case, for custom and wire cloud, accordingly to the latest deployments in prod envs.
But anyway I will check if we are able to use a broader spectrum, just in case to be on the safer side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for now, and we can later look into if this will affect other use cases
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
https://wearezeta.atlassian.net/browse/WPB-5448
Follow up of #2193
Causes (Optional)
Allowed list of specific cipher suites.
Solutions
Configure and add tests for the allowed cipher suites.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.