Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle legal hold events (WPB-5442) #2236

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 20, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

This PR aims to handle legal hold events: legalhold-request, legalhold-enable and legalhold-disable

For legalhold-request, the app will store that request the its data in sharedpreferences.
For legalhold-enable and legalhold-disable, the app will remove current legalhold request(if it's for self user) and update clients(self or other)

Next PR will be for creating a use case for observing pending request

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Unit Test Results

   433 files   -   39     433 suites   - 39   25s ⏱️ - 2m 16s
2 447 tests  - 190  2 369 ✔️  - 164  78 💤  - 26  0 ±0 

Results for commit a72c384. ± Comparison against base commit c44dd05.

♻️ This comment has been updated with latest results.

@ohassine ohassine requested review from MohamadJaara, saleniuk, vitorhugods and mchenani and removed request for gongracr November 21, 2023 11:04
@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 21, 2023

Datadog Report

All test runs b6e2ef0 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2369 78 7m 48.12s Link
kalium-jvm 0 0 0 2537 104 7m 16s Link

@ohassine ohassine enabled auto-merge November 22, 2023 08:03
@codecov-commenter
Copy link

Codecov Report

Merging #2236 (a72c384) into develop (c44dd05) will decrease coverage by 0.04%.
The diff coverage is 52.40%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2236      +/-   ##
=============================================
- Coverage      57.99%   57.95%   -0.04%     
  Complexity        21       21              
=============================================
  Files           1075     1080       +5     
  Lines          40824    41002     +178     
  Branches        3778     3793      +15     
=============================================
+ Hits           23674    23761      +87     
- Misses         15531    15619      +88     
- Partials        1619     1622       +3     
Files Coverage Δ
.../wire/kalium/logic/data/client/ClientRepository.kt 55.05% <100.00%> (-0.50%) ⬇️
...com/wire/kalium/logic/data/legalhold/LastPreKey.kt 100.00% <100.00%> (ø)
...ync/receiver/handler/legalhold/LegalHoldHandler.kt 100.00% <100.00%> (ø)
...eiver/handler/legalhold/LegalHoldRequestHandler.kt 100.00% <100.00%> (ø)
...om/wire/kalium/logic/feature/client/ClientScope.kt 0.00% <0.00%> (ø)
...re/kalium/logic/sync/receiver/UserEventReceiver.kt 79.84% <50.00%> (-2.42%) ⬇️
...twork/api/base/authenticated/client/ClientIdDTO.kt 0.00% <0.00%> (ø)
...kalium/logic/configuration/UserConfigRepository.kt 50.35% <0.00%> (-2.28%) ⬇️
...api/base/authenticated/keypackage/LastPreKeyDTO.kt 0.00% <0.00%> (ø)
...ire/kalium/persistence/dao/unread/UserConfigDAO.kt 26.66% <0.00%> (-9.70%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44dd05...a72c384. Read the comment docs.

@ohassine ohassine added this pull request to the merge queue Nov 22, 2023
Merged via the queue into develop with commit d7d5a72 Nov 22, 2023
17 checks passed
@ohassine ohassine deleted the handle_legal_hold_events branch November 22, 2023 08:56
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
* feat: handle legal hold events

* chore: address comments

* chore: detekt

* chore: detekt

* chore: show user id in logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants