Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: private users can remove app lock even after team enforce #2240

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. App lock settings can be changed, even when enforced by team.
  2. App lock is cleared when the team removes the enforce.

Solutions

  1. add use case to check if the app lock can be modified (if at least one user ha ve it enforced by team).
  2. remove default timeout form klalium (this should be the app responsibility)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…p-lock-even-after-team-enforce

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/featureConfig/handler/AppLockConfigHandler.kt
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Unit Test Results

   439 files     439 suites   26s ⏱️
2 485 tests 2 382 ✔️ 103 💤 0

Results for commit 3fce833.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@884b41a). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2240   +/-   ##
====================================================
  Coverage                     ?   58.06%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1074           
  Lines                        ?    40765           
  Branches                     ?     3775           
====================================================
  Hits                         ?    23669           
  Misses                       ?    15476           
  Partials                     ?     1620           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884b41a...3fce833. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 21, 2023

Datadog Report

All test runs b19fa60 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2382 103 8m 32.1s Link
kalium-jvm 0 0 0 2527 104 7m 12.05s Link

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! just a comment on tests for the new usecase

@MohamadJaara MohamadJaara merged commit 611665a into release/candidate Nov 21, 2023
18 checks passed
@MohamadJaara MohamadJaara deleted the fix/private-users-can-remove-app-lock-even-after-team-enforce branch November 21, 2023 13:03
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
* fix: app lock can be changes when enforced and it is cleared when not enforced

* add docs
github-merge-queue bot pushed a commit that referenced this pull request Nov 23, 2023
#2241)

* fix: app lock can be changes when enforced and it is cleared when not enforced

* add docs

Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
#2241)

* fix: app lock can be changes when enforced and it is cleared when not enforced

* add docs

Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants