-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: private users can remove app lock even after team enforce #2240
fix: private users can remove app lock even after team enforce #2240
Conversation
…p-lock-even-after-team-enforce # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/featureConfig/handler/AppLockConfigHandler.kt
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2240 +/- ##
====================================================
Coverage ? 58.06%
Complexity ? 21
====================================================
Files ? 1074
Lines ? 40765
Branches ? 3775
====================================================
Hits ? 23669
Misses ? 15476
Partials ? 1620 Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! just a comment on tests for the new usecase
...rc/commonMain/kotlin/com/wire/kalium/logic/feature/featureConfig/IsAppLockEditableUseCase.kt
Show resolved
Hide resolved
* fix: app lock can be changes when enforced and it is cleared when not enforced * add docs
#2241) * fix: app lock can be changes when enforced and it is cleared when not enforced * add docs Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
#2241) * fix: app lock can be changes when enforced and it is cleared when not enforced * add docs Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Solutions
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.