Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CC): upgrade cc to rc.18 (WPB-5431) #2245

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore(CC): upgrade cc to rc.18 (WPB-5431) #2245

merged 1 commit into from
Nov 22, 2023

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented Nov 22, 2023 •
edited
Loading

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Upgrade CoreCrypto to 1.0.0-rc.18 to fix the schema migration fixes.

Issues

Fix the db schema migration issue.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

yamilmedina
yamilmedina approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mchenani mchenani changed the title chore(CC): upgrade cc to rc.18 chore(CC): upgrade cc to rc.18 (WPB-5431) Nov 22, 2023
@yamilmedina yamilmedina enabled auto-merge (squash) November 22, 2023 09:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

Unit Test Results

   445 files     445 suites   20s ⏱️
2 514 tests 2 395 ✔️ 119 💤 0 ❌

Results for commit f445e9e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 22, 2023 •
edited
Loading

Datadog Report

All test runs 51c68f3 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2395 119 7m 36.01s Link
kalium-jvm 0 0 0 2503 52 31m 10.01s Link

@yamilmedina yamilmedina merged commit 043e931 into release/candidate Nov 22, 2023
23 of 24 checks passed
@yamilmedina yamilmedina deleted the chore/rc/update-cc-rc18 branch November 22, 2023 10:36
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
6 tasks
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
@mchenani @github-actions
chore(CC): upgrade cc to rc.18 (#2245)
9c7be11
github-merge-queue bot pushed a commit that referenced this pull request Nov 23, 2023
@github-actions @mchenani @saleniuk
chore(CC): upgrade cc to rc.18 (#2245) (#2246)
3d10ef9 
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
augustocdias pushed a commit that referenced this pull request Dec 5, 2023
@github-actions @mchenani
@saleniuk @augustocdias
chore(CC): upgrade cc to rc.18 (#2245) (#2246)
d507918 
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

Assignees

@mchenani mchenani

Labels
👕 size: XS type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchenani @yamilmedina @MohamadJaara