-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: queries, storage and mapping for receiving location messages (WPB-5170) #2285
Conversation
Test Results2 316 tests - 379 2 250 ✔️ - 341 21s ⏱️ - 2m 7s Results for commit 43a6e27. ± Comparison against base commit 5d8695c. This pull request removes 2695 and adds 2316 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 66 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2285 +/- ##
=============================================
- Coverage 58.56% 58.35% -0.21%
Complexity 21 21
=============================================
Files 1093 1094 +1
Lines 41548 41759 +211
Branches 3844 3881 +37
=============================================
+ Hits 24332 24369 +37
- Misses 15590 15751 +161
- Partials 1626 1639 +13
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Location messages are displayed as UnknownContent as today.
Causes (Optional)
Not implemented
Solutions
Implement it, persistence and mapping layer for location messags.
Dependencies (Optional)
PR will follow on AR.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
WIP
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.