Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some end points are not routed through the proxy server #2400

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

some end points are not routed through the proxy server mainly the api version

Solutions

refactore the code so every thing is under the unauthenticated container and make sure is does have the proxy info passed correctly

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

run the app connet to wire server via socks proxy (message me if you need the setup) and in the network inspection only proxy link is used

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Unit Test Results

   413 files     413 suites   24s ⏱️
2 270 tests 2 150 ✔️ 120 💤 0

Results for commit e4347e4.

♻️ This comment has been updated with latest results.

@vitorhugods
Copy link
Member

Why merge it into 4.4.x?

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/android-cycle-4.4.x@1321a90). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             release/android-cycle-4.4.x    #2400   +/-   ##
==============================================================
  Coverage                               ?   58.10%           
  Complexity                             ?       21           
==============================================================
  Files                                  ?     1011           
  Lines                                  ?    37998           
  Branches                               ?     3457           
==============================================================
  Hits                                   ?    22078           
  Misses                                 ?    14443           
  Partials                               ?     1477           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1321a90...e4347e4. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 25, 2024

Datadog Report

Branch report: fix/proxy-mode-does-not-apply-to-all-api-points
Commit report: 8975128
Test service: kalium-jvm

✅ 0 Failed, 2267 Passed, 98 Skipped, 6m 31.04s Wall Time

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests
@MohamadJaara MohamadJaara enabled auto-merge (squash) February 9, 2024 07:06
@MohamadJaara MohamadJaara merged commit b1f1457 into release/android-cycle-4.4.x Feb 9, 2024
14 checks passed
@MohamadJaara MohamadJaara deleted the fix/proxy-mode-does-not-apply-to-all-api-points branch February 9, 2024 07:35
MohamadJaara added a commit that referenced this pull request Feb 12, 2024
* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)
MohamadJaara added a commit that referenced this pull request Feb 19, 2024
)

* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* trigger CI

* fix import

* fix test
MohamadJaara added a commit that referenced this pull request Feb 20, 2024
* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)
MohamadJaara added a commit that referenced this pull request Feb 21, 2024
)

* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* trigger CI

* fix import

* fix test

(cherry picked from commit 5651bb1)
MohamadJaara added a commit that referenced this pull request Feb 29, 2024
* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* fix: merge issues

* fix: some end points are not routed through the proxy server v4.5 (#2485)

* fix: some end points are not routed through the proxy server (#2400)

* fix: some end points are not routed through the proxy server

* fix cli

* fix android sample

* fix test service

* detekt

* fix ios target

* fix tests

* refactor: reimplement update api versions usecase to use proxy (#2414)

* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe

* feat: add proxy URL and need auth indication to custom server dialogs

* fix tests

(cherry picked from commit b1f1457)

* fix cherry pick issues

* detekt

* trigger CI

* fix import

* fix test

(cherry picked from commit 5651bb1)

* fix: merge issues

* cleanup logs

* address PR comments

---------

Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants