-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some end points are not routed through the proxy server #2400
fix: some end points are not routed through the proxy server #2400
Conversation
Why merge it into 4.4.x? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/android-cycle-4.4.x #2400 +/- ##
==============================================================
Coverage ? 58.10%
Complexity ? 21
==============================================================
Files ? 1011
Lines ? 37998
Branches ? 3457
==============================================================
Hits ? 22078
Misses ? 14443
Partials ? 1477 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 2267 Passed, 98 Skipped, 6m 31.04s Wall Time |
* refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests
* fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457)
) * fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * trigger CI * fix import * fix test
* fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457)
) * fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * trigger CI * fix import * fix test (cherry picked from commit 5651bb1)
* fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * fix: merge issues * fix: some end points are not routed through the proxy server v4.5 (#2485) * fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * trigger CI * fix import * fix test (cherry picked from commit 5651bb1) * fix: merge issues * cleanup logs * address PR comments --------- Co-authored-by: Alexandre Ferris <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
some end points are not routed through the proxy server mainly the api version
Solutions
refactore the code so every thing is under the unauthenticated container and make sure is does have the proxy info passed correctly
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
run the app connet to wire server via socks proxy (message me if you need the setup) and in the network inspection only proxy link is used
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.