Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing MLS Conversation (WPB-7085) #2617

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In the logs we would get errors: WelcomeBundle followed by CoreCrypto.ConversationNotFound

Solutions

As we receive the conversationId from the MLSWelcome event, we can first try to fetch conversation if its unknown then get MLSClient

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Test Results

2 836 tests   2 707 ✔️  33s ⏱️
   485 suites     129 💤
   485 files           0

Results for commit 604a55d.

♻️ This comment has been updated with latest results.

@alexandreferris alexandreferris enabled auto-merge (squash) March 11, 2024 16:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/candidate@5c76f00). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2617   +/-   ##
====================================================
  Coverage                     ?   58.39%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1177           
  Lines                        ?    46096           
  Branches                     ?     4366           
====================================================
  Hits                         ?    26917           
  Misses                       ?    17223           
  Partials                     ?     1956           
Files Coverage Δ
...nc/receiver/conversation/MLSWelcomeEventHandler.kt 90.32% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c76f00...604a55d. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/missing_mls_conversation
Commit report: bf2afc1
Test service: kalium-jvm

✅ 0 Failed, 2829 Passed, 123 Skipped, 8m 39.04s Wall Time

@alexandreferris alexandreferris merged commit ef701f4 into release/candidate Mar 11, 2024
17 checks passed
@alexandreferris alexandreferris deleted the fix/missing_mls_conversation branch March 11, 2024 20:51
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
* fix: invert order for fetching conversation if unknown

* fix: tests
github-merge-queue bot pushed a commit that referenced this pull request Mar 12, 2024
* fix: Missing MLS Conversation (WPB-7085) (#2617)

* fix: invert order for fetching conversation if unknown

* fix: tests

* empty trigger commit

---------

Co-authored-by: Alexandre Ferris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants