-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing MLS Conversation (WPB-7085) #2617
fix: Missing MLS Conversation (WPB-7085) #2617
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2617 +/- ##
====================================================
Coverage ? 58.39%
Complexity ? 7
====================================================
Files ? 1177
Lines ? 46096
Branches ? 4366
====================================================
Hits ? 26917
Misses ? 17223
Partials ? 1956
Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 2829 Passed, 123 Skipped, 8m 39.04s Wall Time |
* fix: invert order for fetching conversation if unknown * fix: tests
* fix: Missing MLS Conversation (WPB-7085) (#2617) * fix: invert order for fetching conversation if unknown * fix: tests * empty trigger commit --------- Co-authored-by: Alexandre Ferris <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
In the logs we would get errors:
WelcomeBundle
followed byCoreCrypto.ConversationNotFound
Solutions
As we receive the
conversationId
from the MLSWelcome event, we can first try to fetch conversation if its unknown then get MLSClientDependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.