-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): set ciphersuites when replacing KeyPackages (WPB-10238) #2917
Merged
MohamadJaara
merged 3 commits into
release/android-cycle-4.6
from
fix/set-cs-when-replacing-keypackages
Jul 30, 2024
Merged
fix(e2ei): set ciphersuites when replacing KeyPackages (WPB-10238) #2917
MohamadJaara
merged 3 commits into
release/android-cycle-4.6
from
fix/set-cs-when-replacing-keypackages
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
Jul 30, 2024
Quality Gate passedIssues Measures |
alexandreferris
approved these changes
Jul 30, 2024
borichellow
approved these changes
Jul 30, 2024
Quality Gate passedIssues Measures |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
MohamadJaara
approved these changes
Jul 30, 2024
7 tasks
echoes-hq
bot
added
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
and removed
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
labels
Jul 31, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
After finding some issues on the backend, now it's mandatory to set the CipherSuite when replacing keypackages after E2EI.
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.