Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): set ciphersuites when replacing KeyPackages (WPB-10238) #2917

Merged

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

After finding some issues on the backend, now it's mandatory to set the CipherSuite when replacing keypackages after E2EI.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Test Results

2 902 tests   2 884 ✔️  3m 56s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit 70471de.

♻️ This comment has been updated with latest results.

Copy link

@datadog-wireapp
Copy link

Datadog Report

All test runs 2b80796 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2789 123 1.58s Link
kalium-jvm 0 0 0 2931 107 6.46s Link

@MohamadJaara MohamadJaara merged commit 57a5a7b into release/android-cycle-4.6 Jul 30, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the fix/set-cs-when-replacing-keypackages branch July 30, 2024 13:54
@echoes-hq echoes-hq bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants