Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup MLSCallHelper class (WPB-7153) #2938

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 7, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Renamed MLSCallHelper to CallHelper as it's used also for Proteus.
  • Update documentation

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Test Results

3 054 tests   2 947 ✔️  3m 3s ⏱️
   523 suites     107 💤
   523 files           0

Results for commit 57925f4.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 7, 2024

Datadog Report

All test runs 831f7f4 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2799 123 1.28s Link
kalium-jvm 0 0 0 2947 107 7.2s Link

@ohassine ohassine requested review from a team, typfel, yamilmedina, borichellow, mchenani and Garzas and removed request for a team August 9, 2024 14:53
Copy link

sonarqubecloud bot commented Aug 9, 2024

@MohamadJaara MohamadJaara merged commit 375ca80 into release/android-cycle-4.6 Aug 13, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the cleanup-call-helper branch August 13, 2024 11:10
ohassine added a commit that referenced this pull request Aug 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
* chore: cleanup MLSCallHelper class (#2938)

(cherry picked from commit 375ca80)

* fix: resolve conflicts

* fix: resolve conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants