fix: Validate other members UserName and DisplayName in E2EI [WPB-10402] 🍒 #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: bug / fix 🐞
👕 size: M
🚨 Potential breaking changes
labels
echoes-hq
bot
added
the
echoes: unplanned
…name_and_displayname_in_e2ei-cherry-pick
|
borichellow
approved these changes
Aug 9, 2024
borichellow
requested review from
alexandreferris,
MohamadJaara,
mchenani and
ohassine
Datadog ReportBranch report: ✅ 0 Failed, 3059 Passed, 105 Skipped, 11.94s Total Time |
mchenani
approved these changes
Aug 9, 2024
borichellow
deleted the
fix/validate_other_members_username_and_displayname_in_e2ei-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
The checking "if user has valid E2EI" was not full in Participants list and UserProfile.
We should also check if users
displayNameandhandleare the same as in E2EI certificate.Causes (Optional)
Was not implemented.
Solutions
Implement it and add/update tests for new scenarios.