Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls): set removal-keys for 1on1 calls from conversation-response (WPB-10743) #3009

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fetch and set removal-keys from the create-conversation response for 1on1 conversations and only APIV6

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Test Results

3 065 tests   2 958 ✔️  3m 29s ⏱️
   524 suites     107 💤
   524 files           0

Results for commit 057dde2.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 13, 2024

Datadog Report

All test runs f609b6c 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2805 123 1.41s Link
kalium-jvm 0 0 0 2958 107 6.55s Link

Copy link

@@ -126,6 +128,7 @@ interface MLSConversationRepository {
suspend fun establishMLSGroup(
groupID: GroupID,
members: List<UserId>,
publicKeys: MLSPublicKeys? = null,
Copy link
Member

@MohamadJaara MohamadJaara Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: there are places where this function is called with null and defaulting back to the server keys, mainly JoinExistingMLSConversationUseCaseImpl, MLSMigrator is this expected and what are the potential consciences of this, will it go back to the 50% chance of stuff being broken?
@mchenani

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prekeys we get from the conversation response only needed when we want to create a conversation, there is no need to do so when we joining the existing conversations.

@MohamadJaara MohamadJaara added echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Sep 17, 2024
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take any further discussions to 1:1

@mchenani mchenani enabled auto-merge (squash) September 18, 2024 09:25
@mchenani mchenani merged commit 1b85149 into release/android-cycle-4.6 Sep 18, 2024
19 checks passed
@mchenani mchenani deleted the fix/federated-1on1-removal-keys branch September 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants