-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mls): set removal-keys for 1on1 calls from conversation-response (WPB-10743) #3009
fix(mls): set removal-keys for 1on1 calls from conversation-response (WPB-10743) #3009
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Quality Gate passedIssues Measures |
@@ -126,6 +128,7 @@ interface MLSConversationRepository { | |||
suspend fun establishMLSGroup( | |||
groupID: GroupID, | |||
members: List<UserId>, | |||
publicKeys: MLSPublicKeys? = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: there are places where this function is called with null and defaulting back to the server keys, mainly JoinExistingMLSConversationUseCaseImpl
, MLSMigrator
is this expected and what are the potential consciences of this, will it go back to the 50% chance of stuff being broken?
@mchenani
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prekeys we get from the conversation response only needed when we want to create a conversation, there is no need to do so when we joining the existing conversations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will take any further discussions to 1:1
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Fetch and set removal-keys from the create-conversation response for 1on1 conversations and only APIV6
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.