Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add debug button send FCM token #WPB-9476 #3050

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 4, 2024

TaskWPB-9476 Add a button in the debug settings screen to re-register the FCM push token with the backend

What's new in this PR?

Issues

Changes needed to add button in debug settings that sends FCM push token to the API. If it fails error is displayed.

Dependencies (Optional)

PR wireapp/wire-android#3482 depends on this changes

optionally #3051

Attachments (Optional)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Oct 4, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Test Results

3 216 tests  +4   3 110 ✅ +4   3m 52s ⏱️ -13s
  552 suites +1     106 💤 ±0 
  552 files   +1       0 ❌ ±0 

Results for commit 2e5c7d6. ± Comparison against base commit 8e0f4a6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🐰 Bencher Report

Branchfeat/debug-button-send-fcm-token
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
692,788.74
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
327,775,791.34
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
943,167,878.34
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,940,221.68
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 4, 2024

Datadog Report

Branch report: feat/debug-button-send-fcm-token
Commit report: a409e84
Test service: kalium-jvm

✅ 0 Failed, 3110 Passed, 106 Skipped, 10.94s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (8e0f4a6) to head (2e5c7d6).

Files with missing lines Patch % Lines
.../com/wire/kalium/logic/feature/debug/DebugScope.kt 0.00% 11 Missing ⚠️
...c/feature/notificationToken/SendFCMTokenUseCase.kt 97.05% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3050      +/-   ##
===========================================
+ Coverage    52.50%   52.52%   +0.02%     
===========================================
  Files         1304     1305       +1     
  Lines        50182    50225      +43     
  Branches      4679     4680       +1     
===========================================
+ Hits         26348    26382      +34     
- Misses       21947    21956       +9     
  Partials      1887     1887              
Files with missing lines Coverage Δ
...c/feature/notificationToken/SendFCMTokenUseCase.kt 97.05% <97.05%> (ø)
.../com/wire/kalium/logic/feature/debug/DebugScope.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0f4a6...2e5c7d6. Read the comment docs.

Copy link

sonarqubecloud bot commented Oct 8, 2024

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit 75b92ab Oct 8, 2024
22 checks passed
@damian-kaczmarek damian-kaczmarek deleted the feat/debug-button-send-fcm-token branch October 8, 2024 09:42
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
* feat: Add debug button send FCM token

* reduce returns

* fixed test

* fix datadog report

* after refactor fix

* fix test
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants