Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add debug button send FCM token #WPB-9476 #3482

Merged
merged 8 commits into from
Oct 10, 2024
Merged

feat: Add debug button send FCM token #WPB-9476 #3482

merged 8 commits into from
Oct 10, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 4, 2024 •
edited by github-actions bot
Loading

TaskWPB-9476 Add a button in the debug settings screen to re-register the FCM push token with the backend

What's new in this PR?

Issues

Add button in debug settings that sends FCM push token to the API. If it fails error is displayed.

Needs releases with:

Testing

How to Test

In debug settings there should be new button at the bottom of the screen. It sends the FCM push token to the API

Attachments (Optional)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Oct 4, 2024
@damian-kaczmarek damian-kaczmarek mentioned this pull request Oct 4, 2024
Merged
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.81%. Comparing base (98234f1) to head (773d9f3).
Report is 52 commits behind head on develop.

Files with missing lines Patch % Lines
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 88.88% 2 Missing ⚠️
...e/android/services/WireFirebaseMessagingService.kt 0.00% 2 Missing ⚠️
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3482      +/-   ##
===========================================
+ Coverage    44.43%   44.81%   +0.38%     
===========================================
  Files          466      466              
  Lines        15744    15766      +22     
  Branches      2653     2654       +1     
===========================================
+ Hits          6996     7066      +70     
+ Misses        7991     7939      -52     
- Partials       757      761       +4
Files with missing lines Coverage Δ
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 18.38% <0.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 48.69% <88.88%> (+48.69%) ⬆️
...e/android/services/WireFirebaseMessagingService.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98234f1...773d9f3. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Built wire-android-dev-debug-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Built wire-android-dev-debug-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Built wire-android-dev-debug-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-dev-debug-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-dev-debug-pr-3482.apk is available for download

saleniuk
saleniuk approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-dev-debug-pr-3482.apk is available for download

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3482.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3482.apk is available for download

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 0b8afe7 Oct 10, 2024
12 checks passed
@damian-kaczmarek damian-kaczmarek deleted the feat/debug-button-send-fcm-token branch October 10, 2024 09:51
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@borichellow borichellow Awaiting requested review from borichellow

@Garzas Garzas Awaiting requested review from Garzas

Assignees

@damian-kaczmarek damian-kaczmarek

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damian-kaczmarek @codecov-commenter @MohamadJaara @saleniuk