Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Asset message resend transfer status #WPB-11035 #3063

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Oct 16, 2024

BugWPB-11035 [Android] No error displayed when sending imaged or gifs without internet being availble

https://wearezeta.atlassian.net/browse/WPB-11035

What's new in this PR?

Issues

When we resended asset message, we're not updating its status to uploaded hence the message was stuck with Uploading indicator forever

Solutions

Change the status to Uploaded before trying to again send the message

Testing

How to Test

  • Send any asset message while not having connection, turn on connection again, tap resend, message arrive on the second end and should not be in Uploading state

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Results

3 252 tests  +2   3 146 ✅ +2   4m 23s ⏱️ +8s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 673e97a. ± Comparison against base commit 0bc15da.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchfix/asset-message-transfer-status
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
688,884.23
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
338,957,249.46
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
922,774,759.78
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,308,468.82
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.70%. Comparing base (0bc15da) to head (673e97a).
Report is 4 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3063   +/-   ##
==================================================
  Coverage              52.70%   52.70%           
==================================================
  Files                   1317     1317           
  Lines                  51108    51108           
  Branches                4742     4741    -1     
==================================================
+ Hits                   26936    26937    +1     
+ Misses                 22247    22245    -2     
- Partials                1925     1926    +1     
Files with missing lines Coverage Δ
...logic/feature/message/RetryFailedMessageUseCase.kt 82.88% <100.00%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc15da...673e97a. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 16, 2024

Datadog Report

Branch report: fix/asset-message-transfer-status
Commit report: 4940fdb
Test service: kalium-jvm

✅ 0 Failed, 3146 Passed, 106 Skipped, 34.27s Total Time

@yamilmedina yamilmedina changed the base branch from develop to release/candidate October 16, 2024 08:17
@m-zagorski m-zagorski requested a review from saleniuk October 22, 2024 07:42
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small suggestion, other then that is great 👍

Copy link

@saleniuk saleniuk added this pull request to the merge queue Oct 30, 2024
Merged via the queue into release/candidate with commit 3528f01 Oct 30, 2024
20 checks passed
@saleniuk saleniuk deleted the fix/asset-message-transfer-status branch October 30, 2024 13:03
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
* fix: Asset message resend transfer status #WPB-11035

* Code review
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
* fix: Asset message resend transfer status #WPB-11035

* Code review

Co-authored-by: Mateusz Zagórski <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants