-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Asset message resend transfer status #WPB-11035 #3063
fix: Asset message resend transfer status #WPB-11035 #3063
Conversation
Bencher Report
Click to view all benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3063 +/- ##
==================================================
Coverage 52.70% 52.70%
==================================================
Files 1317 1317
Lines 51108 51108
Branches 4742 4741 -1
==================================================
+ Hits 26936 26937 +1
+ Misses 22247 22245 -2
- Partials 1925 1926 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3146 Passed, 106 Skipped, 34.27s Total Time |
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/message/RetryFailedMessageUseCase.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just small suggestion, other then that is great 👍
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/message/RetryFailedMessageUseCase.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
* fix: Asset message resend transfer status #WPB-11035 * Code review
* fix: Asset message resend transfer status #WPB-11035 * Code review Co-authored-by: Mateusz Zagórski <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
https://wearezeta.atlassian.net/browse/WPB-11035
What's new in this PR?
Issues
When we resended asset message, we're not updating its status to uploaded hence the message was stuck with
Uploading
indicator foreverSolutions
Change the status to Uploaded before trying to again send the message
Testing
How to Test
Uploading
statePR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.