-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] #3085
fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] #3085
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 3145 Passed, 107 Skipped, 28.83s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3085 +/- ##
=====================================================
- Coverage 52.58% 52.57% -0.02%
=====================================================
Files 1318 1319 +1
Lines 51459 51475 +16
Branches 4774 4778 +4
=====================================================
+ Hits 27061 27064 +3
- Misses 22437 22449 +12
- Partials 1961 1962 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ! just maybe the test part could be commented completely instead of ignore so we later uncomment when enabling pagination
.../src/commonTest/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepositoryTest.kt
Show resolved
Hide resolved
.../src/commonTest/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepositoryTest.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
…ginated list [WPB-12070] (#3085) * fix: add use case to get all ConversationDetailsWithEvents for not paginated list * tests * address PR comments * pr comment --------- Co-authored-by: Michał Saleniuk <[email protected]>
…ginated list [WPB-12070] (#3085) (#3088) * fix: add use case to get all ConversationDetailsWithEvents for not paginated list * tests * address PR comments * pr comment --------- Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Michał Saleniuk <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
this PR revet the changes for paginated conversation list
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.