Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] #3085

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Oct 31, 2024

StoryWPB-12070 [Android] place conversation pagination in a feature flag


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

this PR revet the changes for paginated conversation list

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Test Results

3 252 tests   - 2   3 145 ✅  - 3   4m 6s ⏱️ -17s
  555 suites ±0     107 💤 +1 
  555 files   ±0       0 ❌ ±0 

Results for commit 4707c1b. ± Comparison against base commit 8686502.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 31, 2024

Datadog Report

Branch report: fix/add-usecase-to-get-conversationdetailswithevents
Commit report: 41bcbd1
Test service: kalium-jvm

✅ 0 Failed, 3145 Passed, 107 Skipped, 28.83s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.57%. Comparing base (8686502) to head (4707c1b).

Files with missing lines Patch % Lines
.../logic/data/conversation/ConversationRepository.kt 80.00% 2 Missing and 2 partials ⚠️
...rveConversationListDetailsWithEventsUseCaseImpl.kt 0.00% 3 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3085      +/-   ##
=====================================================
- Coverage              52.58%   52.57%   -0.02%     
=====================================================
  Files                   1318     1319       +1     
  Lines                  51459    51475      +16     
  Branches                4774     4778       +4     
=====================================================
+ Hits                   27061    27064       +3     
- Misses                 22437    22449      +12     
- Partials                1961     1962       +1     
Files with missing lines Coverage Δ
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...rveConversationListDetailsWithEventsUseCaseImpl.kt 0.00% <0.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.55% <80.00%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8686502...4707c1b. Read the comment docs.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! just maybe the test part could be commented completely instead of ignore so we later uncomment when enabling pagination

Copy link

sonarqubecloud bot commented Nov 4, 2024

@MohamadJaara MohamadJaara changed the title fix: add use case to get all ConversationDetailsWithEvents for not paginated list fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] Nov 4, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 4, 2024
Merged via the queue into release/candidate with commit 85c189c Nov 4, 2024
22 of 23 checks passed
@MohamadJaara MohamadJaara deleted the fix/add-usecase-to-get-conversationdetailswithevents branch November 4, 2024 17:03
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
…ginated list [WPB-12070] (#3085)

* fix: add use case to get all ConversationDetailsWithEvents for not paginated list

* tests

* address PR comments

* pr comment

---------

Co-authored-by: Michał Saleniuk <[email protected]>
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
…ginated list [WPB-12070] (#3085) (#3088)

* fix: add use case to get all ConversationDetailsWithEvents for not paginated list

* tests

* address PR comments

* pr comment

---------

Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants