-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Recently ended call metadata compact [WPB-14256] #3113
feat: Recently ended call metadata compact [WPB-14256] #3113
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 3182 Passed, 107 Skipped, 40.94s Total Time |
…nded-call-metadata-compact
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/recently-ended-call-metadata #3113 +/- ##
=====================================================================
+ Coverage 54.02% 54.17% +0.14%
=====================================================================
Files 1236 1208 -28
Lines 36095 35894 -201
Branches 3665 3653 -12
=====================================================================
- Hits 19502 19447 -55
+ Misses 15178 15037 -141
+ Partials 1415 1410 -5
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
be6083e
into
feat/recently-ended-call-metadata
* feat: Recently ended call metadata [WPB-14256] * Small test changes * Make use case internal constructor * feat: Recently ended call metadata compact [WPB-14256] (#3113) * Code review * Include screen sharing metadata * Code review --------- Co-authored-by: Yamil Medina <[email protected]>
https://wearezeta.atlassian.net/browse/WPB-14256
What's new in this PR?
Issues
Changed the way metadata is created, in here data is created right away from
OnCloseCall
instead of exposing thecall
andreason
and metadata creation use case.I think I like this more, but it depends if we want to have usecases in our
CallManagerImpl
Causes (Optional)
In the previous solution I feel were exposing too much without the real need
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.