Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Recently ended call metadata compact [WPB-14256] #3113

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 20, 2024

StoryWPB-14256 [Android] Call end - Event and segmentation

https://wearezeta.atlassian.net/browse/WPB-14256

What's new in this PR?

Issues

Changed the way metadata is created, in here data is created right away from OnCloseCall instead of exposing the call and reason and metadata creation use case.
I think I like this more, but it depends if we want to have usecases in our CallManagerImpl

Causes (Optional)

In the previous solution I feel were exposing too much without the real need


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Test Results

3 289 tests   - 5   3 182 ✅  - 5   5m 7s ⏱️ +18s
  560 suites  - 2     107 💤 ±0 
  560 files    - 2       0 ❌ ±0 

Results for commit 0bf6301. ± Comparison against base commit 5c89646.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 20, 2024

Datadog Report

Branch report: feat/recently-ended-call-metadata-compact
Commit report: 7e2dd3f
Test service: kalium-jvm

✅ 0 Failed, 3182 Passed, 107 Skipped, 40.94s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.17%. Comparing base (5c89646) to head (0bf6301).

Files with missing lines Patch % Lines
...reateAndPersistRecentlyEndedCallMetadataUseCase.kt 82.35% 0 Missing and 3 partials ⚠️
...usecase/ObserveRecentlyEndedCallMetadataUseCase.kt 0.00% 2 Missing ⚠️
.../com/wire/kalium/logic/data/call/CallRepository.kt 50.00% 1 Missing ⚠️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           feat/recently-ended-call-metadata    #3113      +/-   ##
=====================================================================
+ Coverage                              54.02%   54.17%   +0.14%     
=====================================================================
  Files                                   1236     1208      -28     
  Lines                                  36095    35894     -201     
  Branches                                3665     3653      -12     
=====================================================================
- Hits                                   19502    19447      -55     
+ Misses                                 15178    15037     -141     
+ Partials                                1415     1410       -5     
Files with missing lines Coverage Δ
.../kalium/logic/feature/call/scenario/OnCloseCall.kt 85.71% <100.00%> (-2.53%) ⬇️
.../com/wire/kalium/logic/data/call/CallRepository.kt 83.33% <50.00%> (+0.63%) ⬆️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% <0.00%> (ø)
...usecase/ObserveRecentlyEndedCallMetadataUseCase.kt 0.00% <0.00%> (ø)
...reateAndPersistRecentlyEndedCallMetadataUseCase.kt 79.48% <82.35%> (ø)

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c89646...0bf6301. Read the comment docs.

---- 🚨 Try these New Features:

@m-zagorski m-zagorski merged commit be6083e into feat/recently-ended-call-metadata Nov 20, 2024
20 checks passed
@m-zagorski m-zagorski deleted the feat/recently-ended-call-metadata-compact branch November 20, 2024 13:45
github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2024
* feat: Recently ended call metadata [WPB-14256]

* Small test changes

* Make use case internal constructor

* feat: Recently ended call metadata compact [WPB-14256]  (#3113)

* Code review

* Include screen sharing metadata

* Code review

---------

Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants