Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore: update sqlcipher [WPB-11808] (#3069)" #3137

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 28, 2024

BugWPB-11808 [Android] app stalls when fetching a page of conversations from the local DB

This reverts commit 96044bc.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

4.6.1 is causing performance issues

Solutions

revert to 4.5.7

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 28, 2024
@MohamadJaara MohamadJaara merged commit b60e679 into release/candidate Nov 28, 2024
14 of 16 checks passed
@MohamadJaara MohamadJaara deleted the revert/bump-sqlcipher branch November 28, 2024 13:01
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.67%. Comparing base (76f6cd1) to head (ee37d00).
Report is 1 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3137   +/-   ##
==================================================
  Coverage              52.67%   52.67%           
==================================================
  Files                   1323     1323           
  Lines                  51730    51730           
  Branches                4803     4803           
==================================================
  Hits                   27250    27250           
- Misses                 22514    22515    +1     
+ Partials                1966     1965    -1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f6cd1...ee37d00. Read the comment docs.

github-merge-queue bot pushed a commit that referenced this pull request Nov 29, 2024
This reverts commit 96044bc.

Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. Fix PR Title 🤦‍♂️ 👕 size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants