Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update federation flag when fetching server config [WPB-14728] #3143

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Dec 3, 2024

BugWPB-14728 [Android] Make sure clients fetch all configurations regularly


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

federation flag was not updated when updating api version

Solutions

update it

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Dec 3, 2024
@MohamadJaara MohamadJaara changed the title Fix/update federation flag when fetching server config [WPB-14728] fix: update federation flag when fetching server config [WPB-14728] Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

3 272 tests   3 165 ✅  4m 41s ⏱️
  558 suites    107 💤
  558 files        0 ❌

Results for commit b2ce0f5.

♻️ This comment has been updated with latest results.

@echoes-hq echoes-hq bot added the echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... label Dec 3, 2024
@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 3, 2024

Datadog Report

Branch report: fix/update-federation-flag-when-fetching-server-config
Commit report: ca5188b
Test service: kalium-jvm

✅ 0 Failed, 3165 Passed, 107 Skipped, 32.39s Total Time

Copy link

sonarqubecloud bot commented Dec 3, 2024

@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/candidate@b60e679). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...gic/configuration/server/ServerConfigRepository.kt 28.57% 10 Missing ⚠️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #3143   +/-   ##
====================================================
  Coverage                     ?   52.67%           
====================================================
  Files                        ?     1323           
  Lines                        ?    51745           
  Branches                     ?     4803           
====================================================
  Hits                         ?    27255           
  Misses                       ?    22524           
  Partials                     ?     1966           
Files with missing lines Coverage Δ
...nfiguration/server/CustomServerConfigRepository.kt 81.48% <100.00%> (ø)
...m/logic/feature/server/UpdateApiVersionsUseCase.kt 83.87% <100.00%> (ø)
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 60.00% <66.66%> (ø)
...gic/configuration/server/ServerConfigRepository.kt 66.66% <28.57%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60e679...b2ce0f5. Read the comment docs.

@MohamadJaara MohamadJaara removed this pull request from the merge queue due to a manual request Dec 3, 2024
@MohamadJaara MohamadJaara merged commit 790b885 into release/candidate Dec 3, 2024
21 checks passed
@MohamadJaara MohamadJaara deleted the fix/update-federation-flag-when-fetching-server-config branch December 3, 2024 12:09
MohamadJaara added a commit that referenced this pull request Dec 19, 2024
…3143)

* fix: update federation flag when updating api version

* fix test

* remove not needed comment

* fix jvm tests

(cherry picked from commit 790b885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants