Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use case to change cipher_profile [WPB-14826] #3163

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 10, 2024

BugWPB-14826 [Android] Conversation list loading very slow after closing a conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Use case and method executing query to enable or disable cipher_profile to get query execution times.
Parameter is platform specific and used only on encrypted database.

Testing

How to Test

After enabling on Android there should be logs with query execution times in logcat.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Test Results

3 340 tests  ±0   3 233 ✅ ±0   5m 50s ⏱️ -9s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 3917dad. ± Comparison against base commit 26b7d4b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 54.12%. Comparing base (26b7d4b) to head (3917dad).

Files with missing lines Patch % Lines
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 25.00% 9 Missing ⚠️
...lium/logic/feature/debug/ChangeProfilingUseCase.kt 0.00% 4 Missing ⚠️
.../com/wire/kalium/logic/feature/debug/DebugScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3163      +/-   ##
===========================================
- Coverage    54.14%   54.12%   -0.03%     
===========================================
  Files         1250     1251       +1     
  Lines        36494    36510      +16     
  Branches      3697     3698       +1     
===========================================
  Hits         19761    19761              
- Misses       15309    15324      +15     
- Partials      1424     1425       +1     
Files with missing lines Coverage Δ
.../com/wire/kalium/logic/feature/debug/DebugScope.kt 0.00% <0.00%> (ø)
...lium/logic/feature/debug/ChangeProfilingUseCase.kt 0.00% <0.00%> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 77.71% <25.00%> (-4.00%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b7d4b...3917dad. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/add-option-to-change-cipher-profile
Commit report: 62b73f9
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 1m 8.53s Total Time

@saleniuk saleniuk requested review from a team, m-zagorski, alexandreferris, Garzas, ohassine and damian-kaczmarek and removed request for a team December 11, 2024 09:12
@saleniuk saleniuk added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit 0667f9b Dec 11, 2024
23 checks passed
@saleniuk saleniuk deleted the feat/add-option-to-change-cipher-profile branch December 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: S type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants