fix: mls client init [WPB-15022] #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
typfel,
yamilmedina,
MohamadJaara and
vitorhugods
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
typfel
reviewed
Dec 16, 2024
| selfTeamIdProvider().getOrNull(), | ||
| val mlsGroupState = conversation.groupId?.let { mlsGroupState(idMapper.fromGroupIDEntity(it), originatedFromEvent) } | ||
| // if group state is left, then we don't want to persist the conversation | ||
| if (mlsGroupState?.fold({ true }, { false }) != true) { |
There was a problem hiding this comment.
Can't we use isRight() instead of fold()?
Suggested change
| if (mlsGroupState?.fold({ true }, { false }) != true) { | |
| if (mlsGroupState?.isRight() |
There was a problem hiding this comment.
I don't know why but tests where failing when I was using is left or right
yamilmedina
approved these changes
Dec 16, 2024
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepository.kt
Outdated
Show resolved
Hide resolved
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3178 +/- ##
==================================================
Coverage 54.14% 54.14%
==================================================
Files 1250 1250
Lines 36458 36477 +19
Branches 3689 3696 +7
==================================================
+ Hits 19740 19751 +11
- Misses 15294 15298 +4
- Partials 1424 1428 +4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3236 Passed, 107 Skipped, 1m 1.13s Total Time |
typfel
approved these changes
Dec 16, 2024
|
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
* fix: secure mls client creation with is mls enabled * fix: dont persist mls conversations when mls is disabled * review improvements
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix: secure mls client creation with is mls enabled * fix: dont persist mls conversations when mls is disabled * review improvements Co-authored-by: Jakub Żerko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There is scenario when mls client can be created when mls feature config is disabled
Causes (Optional)
Before enabling MLS on feature config backend can change
cipherSuiteTagcausing encryption problems when user can already use some defaultcipherSuiteTagif he created MLS client earlier.Solutions
MLSFailure.DisabledMLSKeyPackageCountUseCaseto not fetch key package count when MLS is disabled by feature config