Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle mls disabled error [WPB-15022] #3745

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 16, 2024

BugWPB-15022 [Android] MLS client is created, but not registered once mls keys are available on the backend


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adapt to changes in wireapp/kalium#3178

@Garzas Garzas self-assigned this Dec 16, 2024
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Dec 16, 2024
@Garzas Garzas enabled auto-merge December 16, 2024 15:36
@Garzas Garzas added this pull request to the merge queue Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.73%. Comparing base (90282ea) to head (5d6e24b).
Report is 1 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3745      +/-   ##
=====================================================
- Coverage              45.74%   45.73%   -0.01%     
=====================================================
  Files                    473      473              
  Lines                  16092    16094       +2     
  Branches                2716     2717       +1     
=====================================================
  Hits                    7361     7361              
- Misses                  7970     7972       +2     
  Partials                 761      761              
Files with missing lines Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 67.50% <100.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 54.47% <0.00%> (-0.83%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90282ea...5d6e24b. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3745.apk is available for download

Merged via the queue into release/candidate with commit 0f6eeb5 Dec 16, 2024
14 of 15 checks passed
@Garzas Garzas deleted the fix/handle-mls-disabled-error branch December 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants