feat: Delete local conversation use case [#WPB-14601] #3182
Conversation
|
| @@ -884,6 +885,12 @@ internal class ConversationDataSource internal constructor( | |||
| } | |||
| } | |||
|
|
|||
| override suspend fun deleteLocalConversation(conversationId: ConversationId): Either<CoreFailure, Unit> { | |||
There was a problem hiding this comment.
I was thinking between deleteLocalConversation and deleteConversationLocally - which one would you guys prefer?
There was a problem hiding this comment.
Also there is the deleteConversation but it invoked mls method to nuke the conversation which I think we dont want while removing it locally? Am I right?
|
Bencher Report| Branch | feat/delete-local-conversation-use-case |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 654,149.31 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 421,004,506.00 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,301,926,935.28 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,301,830.50 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3182 +/- ##
===========================================
- Coverage 54.12% 54.09% -0.04%
===========================================
Files 1255 1258 +3
Lines 36641 36697 +56
Branches 3724 3727 +3
===========================================
+ Hits 19831 19850 +19
- Misses 15371 15407 +36
- Partials 1439 1440 +1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3254 Passed, 107 Skipped, 1m 1.69s Total Time |
https://wearezeta.atlassian.net/browse/WPB-14601
What's new in this PR?
Issues
Have an option to delete conversation locally with assets, contents and conversation itself
Solutions
Create use case for clearing assets and create use case for deleting conversation which involves:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.