-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delete local conversation use case [#WPB-14601] #3182
Open
m-zagorski
wants to merge
1
commit into
develop
Choose a base branch
from
feat/delete-local-conversation-use-case
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
.../kotlin/com/wire/kalium/logic/feature/conversation/ClearLocalConversationAssetsUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2024 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
package com.wire.kalium.logic.feature.conversation | ||
|
||
import com.wire.kalium.logic.CoreFailure | ||
import com.wire.kalium.logic.data.asset.AssetRepository | ||
import com.wire.kalium.logic.data.id.ConversationId | ||
import com.wire.kalium.logic.data.message.MessageRepository | ||
import com.wire.kalium.logic.functional.Either | ||
import com.wire.kalium.logic.functional.flatMap | ||
|
||
interface ClearLocalConversationAssetsUseCase { | ||
/** | ||
* Clear all conversation assets from local storage | ||
* | ||
* @param conversationId - id of conversation in which assets should be cleared | ||
*/ | ||
suspend operator fun invoke(conversationId: ConversationId): Either<CoreFailure, Unit> | ||
} | ||
|
||
internal class ClearLocalConversationAssetsUseCaseImpl( | ||
private val messageRepository: MessageRepository, | ||
private val assetRepository: AssetRepository | ||
) : ClearLocalConversationAssetsUseCase { | ||
override suspend fun invoke(conversationId: ConversationId): Either<CoreFailure, Unit> { | ||
return messageRepository.getAllAssetIdsFromConversationId(conversationId) | ||
.flatMap { ids -> | ||
if (ids.isEmpty()) return Either.Right(Unit) | ||
|
||
ids.map { id -> assetRepository.deleteAssetLocally(id) } | ||
.reduce { acc, either -> | ||
acc.flatMap { either } | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
...nMain/kotlin/com/wire/kalium/logic/feature/conversation/DeleteLocalConversationUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2024 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
package com.wire.kalium.logic.feature.conversation | ||
|
||
import com.wire.kalium.logic.CoreFailure | ||
import com.wire.kalium.logic.data.conversation.ConversationRepository | ||
import com.wire.kalium.logic.data.id.ConversationId | ||
import com.wire.kalium.logic.functional.Either | ||
import com.wire.kalium.logic.functional.flatMap | ||
|
||
interface DeleteLocalConversationUseCase { | ||
/** | ||
* Delete local conversation which: | ||
* - Clear all local assets | ||
* - Clear content | ||
* - Remove conversation | ||
* | ||
* @param conversationId - id of conversation to delete | ||
*/ | ||
suspend operator fun invoke(conversationId: ConversationId): Either<CoreFailure, Unit> | ||
} | ||
|
||
internal class DeleteLocalConversationUseCaseImpl( | ||
private val conversationRepository: ConversationRepository, | ||
private val clearLocalConversationAssets: ClearLocalConversationAssetsUseCase | ||
) : DeleteLocalConversationUseCase { | ||
|
||
override suspend fun invoke(conversationId: ConversationId): Either<CoreFailure, Unit> { | ||
return clearLocalConversationAssets(conversationId) | ||
.flatMap { conversationRepository.clearContent(conversationId) } | ||
.flatMap { conversationRepository.deleteLocalConversation(conversationId) } | ||
} | ||
} |
111 changes: 111 additions & 0 deletions
111
...lin/com/wire/kalium/logic/feature/conversation/ClearLocalConversationAssetsUseCaseTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,111 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2024 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
package com.wire.kalium.logic.feature.conversation | ||
|
||
import com.wire.kalium.logic.CoreFailure | ||
import com.wire.kalium.logic.data.asset.AssetRepository | ||
import com.wire.kalium.logic.data.id.ConversationId | ||
import com.wire.kalium.logic.data.message.MessageRepository | ||
import com.wire.kalium.logic.functional.Either | ||
import io.mockative.Mock | ||
import io.mockative.any | ||
import io.mockative.coEvery | ||
import io.mockative.coVerify | ||
import io.mockative.mock | ||
import kotlinx.coroutines.test.runTest | ||
import kotlin.test.Test | ||
import kotlin.test.assertIs | ||
|
||
class ClearLocalConversationAssetsUseCaseTest { | ||
|
||
@Test | ||
fun givenConversationAssetIds_whenAllDeletionsAreSuccess_thenSuccessResultIsPropagated() = runTest { | ||
// given | ||
val ids = listOf("id_1", "id_2") | ||
val (arrangement, useCase) = Arrangement() | ||
.withAssetIdsResponse(ids) | ||
.withAssetClearSuccess("id_1") | ||
.withAssetClearSuccess("id_2") | ||
.arrange() | ||
|
||
// when | ||
val result = useCase(ConversationId("someValue", "someDomain")) | ||
|
||
// then | ||
assertIs<Either.Right<Unit>>(result) | ||
coVerify { arrangement.assetRepository.deleteAssetLocally(any()) }.wasInvoked(exactly = 2) | ||
} | ||
|
||
@Test | ||
fun givenConversationAssetIds_whenOneDeletionFailed_thenFailureResultIsPropagated() = runTest { | ||
// given | ||
val ids = listOf("id_1", "id_2") | ||
val (arrangement, useCase) = Arrangement() | ||
.withAssetIdsResponse(ids) | ||
.withAssetClearSuccess("id_1") | ||
.withAssetClearError("id_2") | ||
.arrange() | ||
|
||
// when | ||
val result = useCase(ConversationId("someValue", "someDomain")) | ||
|
||
// then | ||
assertIs<Either.Left<Unit>>(result) | ||
coVerify { arrangement.assetRepository.deleteAssetLocally(any()) }.wasInvoked(exactly = 2) | ||
} | ||
|
||
@Test | ||
fun givenEmptyConversationAssetIds_whenInvoked_thenDeletionsAreNotInvoked() = runTest { | ||
// given | ||
val (arrangement, useCase) = Arrangement() | ||
.withAssetIdsResponse(emptyList()) | ||
.arrange() | ||
|
||
// when | ||
val result = useCase(ConversationId("someValue", "someDomain")) | ||
|
||
// then | ||
assertIs<Either.Right<Unit>>(result) | ||
coVerify { arrangement.assetRepository.deleteAssetLocally(any()) }.wasNotInvoked() | ||
} | ||
|
||
private class Arrangement { | ||
@Mock | ||
val messageRepository = mock(MessageRepository::class) | ||
|
||
@Mock | ||
val assetRepository = mock(AssetRepository::class) | ||
|
||
suspend fun withAssetClearSuccess(id: String) = apply { | ||
coEvery { assetRepository.deleteAssetLocally(id) }.returns(Either.Right(Unit)) | ||
} | ||
|
||
suspend fun withAssetClearError(id: String) = apply { | ||
coEvery { assetRepository.deleteAssetLocally(id) }.returns(Either.Left(CoreFailure.Unknown(null))) | ||
} | ||
|
||
suspend fun withAssetIdsResponse(ids: List<String>) = apply { | ||
coEvery { messageRepository.getAllAssetIdsFromConversationId(any()) }.returns(Either.Right(ids)) | ||
} | ||
|
||
fun arrange() = this to ClearLocalConversationAssetsUseCaseImpl( | ||
messageRepository = messageRepository, | ||
assetRepository = assetRepository | ||
) | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking between
deleteLocalConversation
anddeleteConversationLocally
- which one would you guys prefer?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there is the
deleteConversation
but it invoked mls method to nuke the conversation which I think we dont want while removing it locally? Am I right?