Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong migrations order between 4.9 and 4.10 [WPB-15157] #3238

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jan 21, 2025

BugWPB-15157 App crashes after receiving links in a group chat


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When cherry-picking the fix for multiple mentions from 4.9 to RC 4.10, the order of migrations were changed - in 4.9 migration related to this fix was added as 91.sqm but in 4.10 as 95.sqm, so it means that when updating the app from 4.9 to 4.10, the app will lose migration that's implemented in 4.10 as 91.sqm because migration with number 91 has already been executed in 4.9.

Solutions

Migration from 91.sqm is about creating ConversationFolder and LabeledConversation, so to fix it, additional migration 96.sqm was created in order to add these tables if they don't yet exist.
Note: this new migration also needs to be added to dev (4.11) to maintain the order there.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 21, 2025
@saleniuk saleniuk requested review from MohamadJaara, a team, yamilmedina, alexandreferris, vitorhugods and Garzas and removed request for a team January 21, 2025 12:05
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Test Results

3 347 tests  ±0   3 239 ✅ ±0   5m 41s ⏱️ +29s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 7365cc0. ± Comparison against base commit ff16a2c.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/wrong-migration-order-between-4.9-and-4.10
Commit report: 47e74c0
Test service: kalium-jvm

✅ 0 Failed, 3239 Passed, 108 Skipped, 1m 2.4s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.50%. Comparing base (ff16a2c) to head (7365cc0).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3238      +/-   ##
=====================================================
- Coverage              54.52%   54.50%   -0.02%     
=====================================================
  Files                   1250     1250              
  Lines                  36524    36524              
  Branches                3696     3696              
=====================================================
- Hits                   19913    19909       -4     
- Misses                 15213    15217       +4     
  Partials                1398     1398              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff16a2c...7365cc0. Read the comment docs.

@saleniuk saleniuk added this pull request to the merge queue Jan 22, 2025
Merged via the queue into release/candidate with commit 55e6c38 Jan 22, 2025
22 checks passed
@saleniuk saleniuk deleted the fix/wrong-migration-order-between-4.9-and-4.10 branch January 22, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT CHERRY PICK echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants