-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong migrations order between 4.9 and 4.10 [WPB-15157] #3238
fix: wrong migrations order between 4.9 and 4.10 [WPB-15157] #3238
Conversation
Quality Gate passedIssues Measures |
Datadog ReportBranch report: ✅ 0 Failed, 3239 Passed, 108 Skipped, 1m 2.4s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3238 +/- ##
=====================================================
- Coverage 54.52% 54.50% -0.02%
=====================================================
Files 1250 1250
Lines 36524 36524
Branches 3696 3696
=====================================================
- Hits 19913 19909 -4
- Misses 15213 15217 +4
Partials 1398 1398 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When cherry-picking the fix for multiple mentions from 4.9 to RC 4.10, the order of migrations were changed - in 4.9 migration related to this fix was added as
91.sqm
but in 4.10 as95.sqm
, so it means that when updating the app from 4.9 to 4.10, the app will lose migration that's implemented in 4.10 as91.sqm
because migration with number 91 has already been executed in 4.9.Solutions
Migration from
91.sqm
is about creatingConversationFolder
andLabeledConversation
, so to fix it, additional migration96.sqm
was created in order to add these tables if they don't yet exist.Note: this new migration also needs to be added to dev (4.11) to maintain the order there.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.