-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app crash when clicking next on create account screen #2183
fix: app crash when clicking next on create account screen #2183
Conversation
APKs built during tests are available here. Scroll down to Artifacts! |
Build 598 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fix, just added a small comment.
.../main/kotlin/com/wire/android/ui/authentication/create/details/CreateAccountDetailsScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable autofill for create account screen since it does not make sense to request saved passwords when creating a new account
Really?
I usually use this functionality to add my password to the password manager before finishing the account creation.
Isn't there another way?
@vitorhugods but with the other changes i did it should work even if we enabled it |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 601 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
app crash when clicking next on create account screen
Causes (Optional)
the
CreateAccountScren
wrap its items in a LazyColumn and when clicking next in the keyboard the password input is not in display (aka not composed) but we do request on focuseChange -> the app crashSolutions
disable autofill for create account screen since it does not make sense to request saved passwords when creating a new account
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.