Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logger with userid and clientid #2280

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Sep 27, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently logs are not associated with specific user and client which makes debugging harder.

Solutions

Create a logger in user scope that can pass userId and clientId with each log.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Test Results

593 tests   592 ✔️  4m 12s ⏱️
  85 suites      1 💤
  85 files        0

Results for commit cc74794.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk marked this pull request as ready for review October 12, 2023 10:15
@saleniuk saleniuk requested review from a team, typfel, gongracr, alexandreferris, borichellow and ohassine and removed request for a team October 12, 2023 10:15
@AndroidBob
Copy link
Collaborator

Build 1255 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1332 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit b5090d9 into release/candidate Oct 16, 2023
11 checks passed
@saleniuk saleniuk deleted the feat/logger-with-userid-and-clientid branch October 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants