feat: hide group creation and edit options for external user [WPB-5749] #2794

saleniuk · 2024-03-15T12:27:06Z

WPB-5749 [Android] Hide group creation buttons for external users

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

External users have the possibility to create groups, add participants to existing groups and edit group name resulting in errors because they shouldn't be allowed to.

Solutions

Check if the user is external and if so then hide option to create group, add participants to the existing group and edit name of the group.
Created dedicated class ItemActionType to choose if the items can be clicked or/and checked.
Cleaned up and unified the state defining the possibilities to edit particular group options according to this table:

for given option to be allowed...	...user needs to be
add participants to group allowed	group admin & not external team member
group name change allowed	group admin & not external team member
group guests option change allowed	group admin & team member of the group owner team
group services option change allowed	group admin
self deleting option change allowed	group admin
group read receipts option change allowed	group admin & group created by a team member

Let me know if any of these conditions is incorrect.

Dependencies (Optional)

Needs releases with:

feat: get userType for SelfUser [WPB-5749] kalium#2653

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Log in as external user and try to create group, add participants to existing group or change the name of the group.

Attachments (Optional)

Screen.Recording.2024-03-14.at.18.27.23.mov

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…tions-for-external-user

github-actions · 2024-03-15T12:31:22Z

Test Results

874 tests +14 874 ✅ +14 16m 48s ⏱️ + 4m 21s
117 suites ± 0 0 💤 ± 0
117 files ± 0 0 ❌ ± 0

Results for commit 71c21b6. ± Comparison against base commit 2ff2e04.

This pull request removes 6 and adds 20 tests. Note that renamed tests count towards both.

com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has no teamId and conversation no teamId, when init group options, then read receipt toggle is disabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has no teamId, is admin and conversation has teamId, when init group options, then read receipt toggle is enabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has no teamId, not admin and conversation has teamId, when init group options, then read receipt toggle is enabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has teamId, is admin and conversation teamId, when init group options, then read receipt toggle is enabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ when no guests and disable service dialog confirmed, then use case is called with the correct values()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ when no guests and enabling services, use case is called with the correct values()

com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and external team member, when init group options, then group name update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and internal team member, when init group options, then group name update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and member of group owner team, when init group options, then guests update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and not member of group owner team, when init group options, then guests update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and not team group, when init group options, then read receipts update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and team group, when init group options, then read receipts update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin, when init group options, then self deleting update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin, when init group options, then services update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is not admin and external team member, when init group options, then group name update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is not admin and internal team member, when init group options, then group name update is not allowed()
…

♻️ This comment has been updated with latest results.

codecov · 2024-03-15T13:04:03Z

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 43.61%. Comparing base (2ff2e04) to head (71c21b6).

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #2794       +/-   ##
============================================
+ Coverage         0   43.61%   +43.61%     
============================================
  Files            0      414      +414     
  Lines            0    13914    +13914     
  Branches         0     2519     +2519     
============================================
+ Hits             0     6069     +6069     
- Misses           0     7137     +7137     
- Partials         0      708      +708

Files	Coverage Δ
...oid/ui/home/conversations/ConversationMemberExt.kt	`75.00% <ø> (ø)`
...s/details/options/GroupConversationOptionsState.kt	`90.90% <100.00%> (ø)`
...participants/model/ConversationParticipantsData.kt	`100.00% <100.00%> (ø)`
...ui/home/conversations/search/SearchPeopleRouter.kt	`0.00% <ø> (ø)`
...i/home/newconversation/NewConversationViewModel.kt	`57.14% <100.00%> (ø)`
...tions/details/GroupConversationDetailsViewModel.kt	`66.66% <87.50%> (ø)`
...participants/GroupConversationParticipantsState.kt	`91.30% <0.00%> (ø)`
...ecase/ObserveParticipantsForConversationUseCase.kt	`86.48% <66.66%> (ø)`
...tlin/com/wire/android/migration/MigrationMapper.kt	`4.34% <0.00%> (ø)`
...in/kotlin/com/wire/android/model/ItemActionType.kt	`0.00% <0.00%> (ø)`

... and 404 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff2e04...71c21b6. Read the comment docs.

github-actions · 2024-03-15T13:13:57Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-15T13:42:32Z

Build 3623 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9154006)(9154006)-staging-compat.apk

…tions-for-external-user # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModel.kt # app/src/test/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModelArrangement.kt

github-actions · 2024-03-15T14:31:25Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-15T15:02:03Z

Build 3628 failed.

…tions-for-external-user

AndroidBob · 2024-03-15T17:19:10Z

Build 3633 failed.

…tions-for-external-user

github-actions · 2024-03-15T18:41:50Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-15T19:04:58Z

Build 3636 failed.

github-actions · 2024-03-15T21:24:38Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-15T21:52:25Z

Build 3637 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9156977)(9156977)-staging-compat.apk

github-actions · 2024-03-18T16:59:01Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-18T17:20:04Z

Build 3642 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9181277)(9181277)-staging-compat.apk

saleniuk added 2 commits March 15, 2024 12:48

feat: hide group creation and edit options for external user [WPB-5749]

261533d

Merge remote-tracking branch 'origin/develop' into feat/hide-group-op…

a19cd0a

…tions-for-external-user

pull-request-size bot added the size/L label Mar 15, 2024

github-actions bot assigned saleniuk Mar 15, 2024

fix detekt

159f515

saleniuk added 2 commits March 15, 2024 18:02

update kalium ref

01d9f2b

Merge remote-tracking branch 'origin/develop' into feat/hide-group-op…

81ddf0e

…tions-for-external-user

Merge remote-tracking branch 'origin/develop' into feat/hide-group-op…

6b283f2

…tions-for-external-user

trigger build

40ee96d

saleniuk requested review from a team, alexandreferris, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team March 18, 2024 08:48

Garzas approved these changes Mar 18, 2024

View reviewed changes

saleniuk mentioned this pull request Mar 18, 2024

feat: update flow for new group conversation creation [WPB-1630] #2797

Merged

6 tasks

mchenani approved these changes Mar 18, 2024

View reviewed changes

ohassine approved these changes Mar 18, 2024

View reviewed changes

update kalium ref

71c21b6

saleniuk enabled auto-merge March 18, 2024 16:25

saleniuk added this pull request to the merge queue Mar 18, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024

saleniuk added this pull request to the merge queue Mar 18, 2024

Merged via the queue into develop with commit 40e0afb Mar 18, 2024
15 checks passed

saleniuk deleted the feat/hide-group-options-for-external-user branch March 18, 2024 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: hide group creation and edit options for external user [WPB-5749] #2794

feat: hide group creation and edit options for external user [WPB-5749] #2794

saleniuk commented Mar 15, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 15, 2024 •

edited

Loading

codecov bot commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 18, 2024

AndroidBob commented Mar 18, 2024

feat: hide group creation and edit options for external user [WPB-5749] #2794

feat: hide group creation and edit options for external user [WPB-5749] #2794

Conversation

saleniuk commented Mar 15, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Mar 15, 2024 • edited Loading

Test Results

codecov bot commented Mar 15, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

AndroidBob commented Mar 15, 2024

github-actions bot commented Mar 18, 2024

AndroidBob commented Mar 18, 2024

saleniuk commented Mar 15, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 15, 2024 •

edited

Loading

codecov bot commented Mar 15, 2024 •

edited

Loading