Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) - cherrypick #2808

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Mar 25, 2024

BugWPB-7114 [Android] When video is enabled on precall screen, video is not streamed during 1:1 and group call


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #2801

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested a review from MohamadJaara March 25, 2024 10:19
@ohassine ohassine assigned alexandreferris and unassigned ohassine Mar 25, 2024
@ohassine ohassine enabled auto-merge (squash) March 25, 2024 10:32
@ohassine ohassine merged commit 6833d5f into release/candidate Mar 25, 2024
12 of 13 checks passed
@ohassine ohassine deleted the calling_video_not_streamed_rc branch March 25, 2024 10:42
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants