fix: Websocket toggle always off [WBP-8669] #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
alexandreferris,
MohamadJaara,
Garzas,
ohassine and
saleniuk
yamilmedina
approved these changes
May 13, 2024
Test Results927 tests 927 ✅ 10m 44s ⏱️ Results for commit e0b6272. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4725 succeeded. The build produced the following APK's: |
vitorhugods
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
In NetworkSetting screen: toggle of Persistent Websocket connection is always off, even when Persistent Connection is on.
Causes (Optional)
The state of toggle is remembered and is not re-composed after state changing.
Solutions
Fix it