Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proximity sensor keeps turning the screen off even when there is no call (WPB-9215) #3045

Merged
merged 1 commit into from
May 29, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 28, 2024

BugWPB-9215 [Android] Screen dimming is on even when there are no active calls


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Proximity sensor keeps turning the screen off even when there is no call

Causes (Optional)

We are not releasing wakeLock when unregistering the sensor listener

Solutions

Release wakeLock if it's held when unregistering the listener

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

STR:

  • Receive an incoming call
  • Turn off the screen by hiding the sensor
  • The caller should end the call
    --> the phone will keep dimming the screen even the app is not open

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, MohamadJaara, vitorhugods, Garzas and saleniuk and removed request for a team May 28, 2024 11:32
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ohassine ohassine requested a review from alexandreferris May 28, 2024 11:47
Copy link
Contributor

Test Results

928 tests   928 ✅  12m 45s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit bf4737a.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5043 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit 3399e44 into release/candidate May 29, 2024
27 checks passed
@ohassine ohassine deleted the proximity-sensor-keeps-working branch May 29, 2024 09:16
github-actions bot pushed a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants