fix: crash when loading what's new section [WPB-9810] #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results827 tests 827 ✅ 7m 35s ⏱️ Results for commit ac38a48. ♻️ This comment has been updated with latest results. |
saleniuk
requested review from
a team,
yamilmedina,
alexandreferris,
vitorhugods,
mchenani and
ohassine
and removed request for
a team
|
APKs built during tests are available here. Scroll down to Artifacts! |
Garzas
approved these changes
Jun 27, 2024
app/src/main/kotlin/com/wire/android/ui/home/whatsnew/WhatsNewItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/whatsnew/WhatsNewItem.kt
Outdated
Show resolved
Hide resolved
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
alexandreferris
approved these changes
Jun 27, 2024
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
On Bund build Column 3, The Android app crashes when the user presses on the "What's New" section in version 4.6.3.
Causes (Optional)
Probably because
url_rss_release_notesis not present in bund build config.Solutions
Move this url to string resources so that it's always available, all builds have the same release notes for its versions.
Add loading state for the "what's new" screen.
Testing
Test Coverage (Optional)
How to Test
Open drawer menu and select "what's new".
Attachments (Optional)
Screen_recording_20240626_144635.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.