-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve audio file size [WPB-10001] #3261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! just have 2 comments on the sampling rate and how/when we delete the used files
...src/main/kotlin/com/wire/android/ui/home/messagecomposer/recordaudio/RecordAudioViewModel.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/recordaudio/AudioMediaRecorder.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a small suggestion, about bulletproofing the resources' closure.
app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/recordaudio/AudioMediaRecorder.kt
Outdated
Show resolved
Hide resolved
Should we merge it into RC ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3261 +/- ##
=====================================================
- Coverage 44.56% 44.30% -0.27%
=====================================================
Files 453 453
Lines 15192 15282 +90
Branches 2525 2550 +25
=====================================================
Hits 6771 6771
- Misses 7703 7793 +90
Partials 718 718
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3261.apk is available for download |
Built wire-android-internal-compat-pr-3261.apk is available for download |
…-android-reloaded into fix/improve-audio-file-size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3261.apk is available for download |
Built wire-android-internal-compat-pr-3261.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Files saved in wav format are pretty big. So we decided to encode it with or without filters on wav but before sending convert with AAC encoding and decrease
SAMPLING_RATE
to 16k