Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiline topbar title still sometimes not centered [WPB-9608] #3278

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Aug 2, 2024

BugWPB-9608 [Android] Heading of own devices not centralised anymore


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

It's a follow up to this PR #3239 to also fix one edge case.

Issues

The title is not centered for some specific title text lenghts.

Causes (Optional)

Text lines lengths was being calculated without taking paddings into account, so in some specific cases it could still be not centered - if the text without paddings (we use 6.dp) would fit in one line but with paddings included it would need to be splitted into two lines.

Solutions

Move paddings to the parent box so that calculated text constraints and actual Text composable widths are exactly the same.
Title for one of previews is modified to also be just long enough to fall into this edge case.

Testing

How to Test

On some devices the name created from the emulator "google sdk_gphone64_arm64 [beta_debug]" was just long enough to fall into this edge case.

Attachments (Optional)

Before After
title_centered_padding_before title_centered_padding_after

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, borichellow, mchenani, Garzas and ohassine and removed request for a team August 2, 2024 15:09
Copy link

sonarqubecloud bot commented Aug 2, 2024

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Built wire-android-staging-compat-pr-3278.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Built wire-android-internal-compat-pr-3278.apk is available for download

@saleniuk saleniuk added this pull request to the merge queue Aug 5, 2024
Merged via the queue into release/candidate with commit 65bdbb4 Aug 5, 2024
12 of 13 checks passed
@saleniuk saleniuk deleted the fix/topbar-title-centered-with-paddings branch August 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants