-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do not send data to Analytics on custom backend (WPB-10020) #3294
chore: Do not send data to Analytics on custom backend (WPB-10020) #3294
Conversation
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
…n_custom_backend' into chore/do_not_send_countly_data_on_custom_backend
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3294 +/- ##
==================================================
Coverage 44.43% 44.44%
==================================================
Files 453 453
Lines 15298 15302 +4
Branches 2552 2554 +2
==================================================
+ Hits 6798 6801 +3
- Misses 7784 7785 +1
Partials 716 716
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3294.apk is available for download |
Built wire-android-internal-compat-pr-3294.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
…3294) Signed-off-by: alexandreferris <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We were sending analytics to custom backends (and not only prod)
Causes (Optional)
No verification was implemented
Solutions
Add verification of current API URL and verify agains PROD API URL so ignoring any other custom backend (staging included).
Testing
Test Coverage (Optional)
How to Test
-- Test 1
-- Test 2