Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing verification for analytics toggle (WPB-10587) #3378

Merged
merged 3 commits into from
Aug 27, 2024
Merged

fix: missing verification for analytics toggle (WPB-10587) #3378

merged 3 commits into from
Aug 27, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 27, 2024 •
edited by github-actions bot
Loading

StoryWPB-10587 [Android] Hide/Show Analytics Toggle in Privacy Settings Screen

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When on custom backends (different from PROD or STAGING) we were showing the analytics toggle in Privacy Settings Screen

Causes (Optional)

We had the verification already set but was not being used

Solutions

Use state attribute containing the value to show or hide the analytics toggle

Testing

How to Test

  • Run App on PROD/STAGING -> dialog/toggle should be shown
  • Run App on custom backend (Anta for example) -> dialog/toggle should NOT be shown

@alexandreferris alexandreferris self-assigned this Aug 27, 2024
@alexandreferris alexandreferris requested review from a team, typfel, mchenani, Garzas, ohassine and saleniuk and removed request for a team August 27, 2024 07:32
@alexandreferris
chore: detekt
2453c89 
Signed-off-by: alexandreferris <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3378.apk is available for download

@alexandreferris alexandreferris added this pull request to the merge queue Aug 27, 2024
Merged via the queue into release/candidate with commit 7887df8 Aug 27, 2024
12 of 13 checks passed
@alexandreferris alexandreferris deleted the fix/missing_verification_for_analytics_toggle branch August 27, 2024 08:30
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@alexandreferris @github-actions
fix: missing verification for analytics toggle (WPB-10587) (#3378)
be5fe6f 
Signed-off-by: alexandreferris <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreferris @MohamadJaara @Garzas