Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update analytics dialog string (WPB-9973) #3422

Merged
merged 1 commit into from
Sep 9, 2024
Merged

chore: update analytics dialog string (WPB-9973) #3422

merged 1 commit into from
Sep 9, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Sep 9, 2024 •
edited by github-actions bot
Loading

StoryWPB-9973 [Android] data collection for free users

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Wrong company naming on analytics dialog text

Solutions

Adjust string with latest copy

Testing

How to Test

  • Have a build with Analytics enabled
  • dialog is shown on fresh login and dialog copy is correct

@alexandreferris alexandreferris self-assigned this Sep 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and saleniuk and removed request for a team September 9, 2024 07:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Built wire-android-staging-compat-pr-3422.apk is available for download

@alexandreferris alexandreferris added this pull request to the merge queue Sep 9, 2024
Merged via the queue into release/candidate with commit 7646333 Sep 9, 2024
14 checks passed
@alexandreferris alexandreferris deleted the chore/update_analytics_dialog_string branch September 9, 2024 09:10
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
@alexandreferris @github-actions
chore: update analytics dialog string (WPB-9973) (#3422)
26e9d84 
Signed-off-by: alexandreferris <[email protected]>
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreferris @yamilmedina @saleniuk