feat: Add accessibility strings to conversation details [WPB-9784] #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
changed the title
echoes-hq
bot
added
the
echoes: product-roadmap
borichellow
requested review from
saleniuk,
Garzas and
yamilmedina
and removed request for
saleniuk and
Garzas
yamilmedina
approved these changes
Oct 10, 2024
Garzas
reviewed
Oct 11, 2024
| @@ -344,6 +344,7 @@ enum class LoginTabItem(@StringRes val titleResId: Int) : TabItem { | |||
| EMAIL(R.string.login_tab_email), | |||
| SSO(R.string.login_tab_sso); | |||
| override val title: UIText = UIText.StringResource(titleResId) | |||
| override val contentDescription: UIText? = null // TODO set contentDescription if needed | |||
| import com.wire.android.ui.home.conversationslist.common.CollapsingFolderHeader | ||
| import com.wire.android.ui.home.conversationslist.common.FolderHeader | ||
|
|
||
| @Suppress("LongParameterList") | ||
| @Suppress("LongParameterList", "CyclomaticComplexMethod") |
There was a problem hiding this comment.
Can we improve it to not having additional suppress?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3495 +/- ##
=====================================================
- Coverage 45.32% 45.31% -0.01%
=====================================================
Files 470 470
Lines 15692 15694 +2
Branches 2626 2626
=====================================================
Hits 7112 7112
- Misses 7836 7838 +2
Partials 744 744
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3495.apk is available for download |
|
Built wire-android-dev-debug-pr-3495.apk is available for download |
yamilmedina
approved these changes
Oct 16, 2024
…o_conversation_details
|
|
Built wire-android-staging-compat-pr-3495.apk is available for download |
Garzas
approved these changes
Oct 21, 2024
borichellow
deleted the
feat/add_accessibility_string_to_conversation_details
branch
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Added accessibility strings to ConversationDetails screen.
This is the first part of work, but it's already to big, one more PR is coming :)