-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wrap persistent connection service in try [WPB-11113] #3532
fix: Wrap persistent connection service in try [WPB-11113] #3532
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3532 +/- ##
===========================================
- Coverage 45.32% 45.27% -0.06%
===========================================
Files 470 470
Lines 15692 15699 +7
Branches 2626 2626
===========================================
- Hits 7112 7107 -5
- Misses 7836 7849 +13
+ Partials 744 743 -1
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3532.apk is available for download |
Built wire-android-dev-debug-pr-3532.apk is available for download |
the fix version for this one is 4.9 can you please do the cherry pick to RC |
What's new in this PR?
Issues
crashes in PlayStore https://play.google.com/console/u/0/developers/7098984309886892484/app/4973241010395499500/vitals/crashes/76ed8eaea06144fa56bcc122f39cd8a0/details?days=28&versionCode=100020981
Causes (Optional)
this happens when PersistentConnection Service is killed by some reason and restarted by OS from background.
Solutions
Basically the issue is on Android side, for now google suggests
try-catch
workaround onlyhttps://issuetracker.google.com/issues/307329994#comment86
Also I've updated
StartPersistentWebsocketIfNecessaryUseCase
to useServicesManager
for starting Service instead of doing it directly. So we have 1 place where all the Services started from.