Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update api version on startup [WPB-14730] #3699

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 3, 2024

BugWPB-14730 [Android] Fetch api version on app startup


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added update api version on app startup to resolve issue with updating flags right away not after 24h when on backend some flags has been changed

@Garzas Garzas changed the title fix: update api version on startup fix: update api version on startup [WPB-14728] Dec 3, 2024
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Dec 3, 2024
@Garzas Garzas changed the title fix: update api version on startup [WPB-14728] fix: update api version on startup [WPB-14730] Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.92%. Comparing base (ec33458) to head (d52f0cf).
Report is 1 commits behind head on release/candidate.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3699   +/-   ##
==================================================
  Coverage              44.91%   44.92%           
==================================================
  Files                    472      472           
  Lines                  15757    15759    +2     
  Branches                2694     2694           
==================================================
+ Hits                    7077     7079    +2     
  Misses                  7924     7924           
  Partials                 756      756           
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt 71.33% <100.00%> (ø)
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 76.92% <100.00%> (+1.92%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec33458...d52f0cf. Read the comment docs.

@Garzas Garzas enabled auto-merge December 3, 2024 09:57
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Built wire-android-staging-compat-pr-3699.apk is available for download

Copy link

sonarqubecloud bot commented Dec 3, 2024

@Garzas Garzas added this pull request to the merge queue Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Built wire-android-staging-compat-pr-3699.apk is available for download

Merged via the queue into release/candidate with commit dd0eec8 Dec 3, 2024
14 checks passed
@Garzas Garzas deleted the fix/update-api-version-on-startup branch December 3, 2024 11:40
MohamadJaara pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants