Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more debug information (WPB-14930) #3725

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

sergeibakhtiarov
Copy link
Contributor

@sergeibakhtiarov sergeibakhtiarov commented Dec 10, 2024

TaskWPB-14930 [Android] Add more debug information to internal builds

https://wearezeta.atlassian.net/browse/WPB-14930


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As a way to help us troubleshoot our own app, in moments like now (December 2024) when a couple of important milestones needs to be achieved (MLS, federation). We want to have more information on internal builds.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Testing

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.76%. Comparing base (1f1e393) to head (198330f).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3725      +/-   ##
=====================================================
+ Coverage              45.70%   45.76%   +0.06%     
=====================================================
  Files                    473      473              
  Lines                  16052    16072      +20     
  Branches                2713     2716       +3     
=====================================================
+ Hits                    7336     7356      +20     
  Misses                  7955     7955              
  Partials                 761      761              
Files with missing lines Coverage Δ
...com/wire/android/ui/debug/DebugDataOptionsState.kt 100.00% <100.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 55.30% <100.00%> (+6.60%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1e393...198330f. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3725.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3725.apk is available for download

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About localising the debug screen... we definitely don't need to translate stuff that is behind PRIVATE_BUILD or DEBUG flags.
But using the String resources would be nice to avoid unnecessary lint and IDE warnings, etc.

Copy link
Contributor

Built wire-android-staging-compat-pr-3725.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3725.apk is available for download

@sergeibakhtiarov sergeibakhtiarov added this pull request to the merge queue Dec 11, 2024
Merged via the queue into release/candidate with commit 72f71e1 Dec 11, 2024
13 of 14 checks passed
@sergeibakhtiarov sergeibakhtiarov deleted the feat/add-more-debug-info branch December 11, 2024 14:59
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants