-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more debug information (WPB-14930) #3725
Conversation
5f5acff
to
97e5588
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3725 +/- ##
=====================================================
+ Coverage 45.70% 45.76% +0.06%
=====================================================
Files 473 473
Lines 16052 16072 +20
Branches 2713 2716 +3
=====================================================
+ Hits 7336 7356 +20
Misses 7955 7955
Partials 761 761
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3725.apk is available for download |
Built wire-android-staging-compat-pr-3725.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About localising the debug screen... we definitely don't need to translate stuff that is behind PRIVATE_BUILD
or DEBUG
flags.
But using the String resources would be nice to avoid unnecessary lint and IDE warnings, etc.
Built wire-android-staging-compat-pr-3725.apk is available for download |
9063f9a
to
02cc615
Compare
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3725.apk is available for download |
Co-authored-by: sergei.bakhtiarov <[email protected]>
https://wearezeta.atlassian.net/browse/WPB-14930
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
As a way to help us troubleshoot our own app, in moments like now (December 2024) when a couple of important milestones needs to be achieved (MLS, federation). We want to have more information on internal builds.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Testing
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.