Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-11973] Freeze API version 7, create dev API version 8. #4356

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Dec 3, 2024

Checklist

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 3, 2024
@stefanwire stefanwire force-pushed the WPB-11973-bump-api-version branch from 4612145 to 645bb7a Compare December 5, 2024 14:45
@fisx
Copy link
Contributor Author

fisx commented Dec 5, 2024

some of the current failures:

----- Events.testConsumeEventsAckNewEventWithoutAckingOldOne FAIL (10.07 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:176


----- Events.testConsumeEventsAcks FAIL (10.06 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:127


----- Events.testChannelLimit FAIL (12.79 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:321

3. k at test/Testlib/ModService.hs:52

4. withModifiedBackend at test/Test/Events.hs:302


----- Events.testConsumeEventsForDifferentUsers FAIL (10.15 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:79

3. assertClientAdd at test/Test/Events.hs:74


----- Events.testConsumeEventsMultipleAcks FAIL (10.08 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:152


----- Events.testConsumeEventsOneWebSocket FAIL (10.06 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:36


----- Events.testConsumeEventsWhileHavingLegacyClients FAIL (10.12 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:110


----- Events.testEventsDeadLettered FAIL (13.04 s) -----
assertion failure:
No event received for 1s

call stack:
1. assertFailure at test/Test/Events.hs:418

2. assertEvent at test/Test/Events.hs:218

3. k at test/Testlib/ModService.hs:52

4. withModifiedBackend at test/Test/Events.hs:203

@stefanwire stefanwire force-pushed the WPB-11973-bump-api-version branch from 645bb7a to cd43dcd Compare December 6, 2024 10:18
fisx added 3 commits December 6, 2024 11:27
This way we get an error if we forget that spot during the next
version freeze.
@fisx
Copy link
Contributor Author

fisx commented Dec 6, 2024

looks good to me! if somebody can review for the green mark, we're ok to merge.

Copy link
Contributor

@stefanwire stefanwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better with one more independent review.

@fisx
Copy link
Contributor Author

fisx commented Dec 6, 2024

talked to stefan and we agreed we're good!

@fisx fisx merged commit 68c68b1 into develop Dec 6, 2024
11 checks passed
@fisx fisx deleted the WPB-11973-bump-api-version branch December 6, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: personal-users-to-team-users... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants