RabbitMQ temporary clients #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
rabbitmq-temp
branch
from
27df25b to
8531659
Compare
zebot
added
the
ok-to-test
supersven
force-pushed
the
rabbitmq-temp
branch
from
8abd99c to
dd5f9cd
Compare
pcapriotti
force-pushed
the
rabbitmq-temp
branch
from
9e3e64a to
7e91fc5
Compare
pcapriotti
force-pushed
the
rabbitmq-temp
branch
from
7e91fc5 to
07f3f73
Compare
We need this between channel creation and message consumption. Thus, we have to squeeze this action into the setup.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements "temporary" queues for listening to events not bound to a specific client, meant to be used by team management or similar services.
When
GET /eventsis called without aclient_idparameter, we create a new temporary queue and bind it to theuser-notificationsexchange with routing keys<user-id>and<user-id>.temporary.When a notification is published to RabbitMQ to all clients of a user, nothing changes, and
<user-id>is used as its routing key. When it is published to a list of clients, it is now also published with routing key<user-id>.temporary. Each notifications is only published once with the<user-id>.temporaryrouting key even if the user has multiple capable clients.When the websocket is closed, the temporary queue is deleted.
https://wearezeta.atlassian.net/browse/WPB-11173
Checklist
changelog.d