[FE] refactor after merge #643, #642 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semnil5202
approved these changes
Jan 29, 2024
| @@ -2,3 +2,6 @@ import { TopicCardProps } from '../../types/Topic'; | |||
| import { http } from './http'; | |||
|
|
|||
| export const getTopics = (url: string) => http.get<TopicCardProps[]>(url); | |||
|
|
|||
| export const getProfile = () => | |||
| http.get<TopicCardProps[] | null>('/members/my/topics'); | |||
There was a problem hiding this comment.
오호.. 북마크 작업할 때 null일수도 있다는걸 제가 간과한거 같은데 이 부분 수정해야겠군요..
Comment on lines
-8
to
+10
| 'https://dr702blqc4x5d.cloudfront.net/2023-map-be-fine/icon/topic_defaultImage.svg'; | ||
| 'https://velog.velcdn.com/images/semnil5202/post/37f3bcb9-0b07-4100-85f6-f1d5ad037c14/image.svg'; | ||
| export const DEFAULT_PROFILE_IMAGE = | ||
| 'https://dr702blqc4x5d.cloudfront.net/2023-map-be-fine/icon/profile_defaultImage.svg'; | ||
| 'https://avatars.githubusercontent.com/u/103165859?v=4'; |
There was a problem hiding this comment.
차라리 이미지 호스팅 서비스를 이용하는게 나을려나요?
There was a problem hiding this comment.
기본 이지미라 저는 괜찮다고 생각하기는 하는데 흠... 호스팅 서비스를 이용하면 더 안정적인 걸까요?!
Comment on lines
-28
to
-29
| const queryClient = new QueryClient(); | ||
|
|
There was a problem hiding this comment.
그 제가 적용한 기본옵션 자동 refetch 옵션 대부분 false 처리해두었는데 이 부분 추후에 정책적으로 회의 한 번 해보시죠~
GC-Park
approved these changes
Jan 29, 2024
| @@ -2,3 +2,6 @@ import { TopicCardProps } from '../../types/Topic'; | |||
| import { http } from './http'; | |||
|
|
|||
| export const getTopics = (url: string) => http.get<TopicCardProps[]>(url); | |||
|
|
|||
| export const getProfile = () => | |||
| http.get<TopicCardProps[] | null>('/members/my/topics'); | |||
Comment on lines
-8
to
+10
| 'https://dr702blqc4x5d.cloudfront.net/2023-map-be-fine/icon/topic_defaultImage.svg'; | ||
| 'https://velog.velcdn.com/images/semnil5202/post/37f3bcb9-0b07-4100-85f6-f1d5ad037c14/image.svg'; | ||
| export const DEFAULT_PROFILE_IMAGE = | ||
| 'https://dr702blqc4x5d.cloudfront.net/2023-map-be-fine/icon/profile_defaultImage.svg'; | ||
| 'https://avatars.githubusercontent.com/u/103165859?v=4'; |
There was a problem hiding this comment.
기본 이지미라 저는 괜찮다고 생각하기는 하는데 흠... 호스팅 서비스를 이용하면 더 안정적인 걸까요?!
Comment on lines
-28
to
-29
| const queryClient = new QueryClient(); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
세인 패트릭꺼 중복된거 충돌 수정했는데 확인 부탁요