-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] refactor after merge #643, #642 #649
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,9 @@ export const SIDEBAR = '372px'; | |
export const LAYOUT_PADDING = '40px'; | ||
|
||
export const DEFAULT_TOPIC_IMAGE = | ||
'https://dr702blqc4x5d.cloudfront.net/2023-map-be-fine/icon/topic_defaultImage.svg'; | ||
'https://velog.velcdn.com/images/semnil5202/post/37f3bcb9-0b07-4100-85f6-f1d5ad037c14/image.svg'; | ||
export const DEFAULT_PROFILE_IMAGE = | ||
'https://dr702blqc4x5d.cloudfront.net/2023-map-be-fine/icon/profile_defaultImage.svg'; | ||
'https://avatars.githubusercontent.com/u/103165859?v=4'; | ||
Comment on lines
-8
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 차라리 이미지 호스팅 서비스를 이용하는게 나을려나요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 기본 이지미라 저는 괜찮다고 생각하기는 하는데 흠... 호스팅 서비스를 이용하면 더 안정적인 걸까요?! |
||
|
||
export const DEFAULT_PROD_URL = | ||
process.env.APP_URL || 'https://mapbefine.com/api'; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; | |
import ReactDOM from 'react-dom/client'; | ||
import ReactGA from 'react-ga4'; | ||
import { ThemeProvider } from 'styled-components'; | ||
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; | ||
|
||
import App from './App'; | ||
import ErrorBoundary from './components/ErrorBoundary'; | ||
|
@@ -25,8 +24,6 @@ const rootElement = document.getElementById('root'); | |
if (!rootElement) throw new Error('Failed to find the root element'); | ||
const root = ReactDOM.createRoot(rootElement); | ||
|
||
const queryClient = new QueryClient(); | ||
|
||
Comment on lines
-28
to
-29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 그 제가 적용한 기본옵션 자동 refetch 옵션 대부분 false 처리해두었는데 이 부분 추후에 정책적으로 회의 한 번 해보시죠~ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 네넹! |
||
// if (process.env.NODE_ENV === 'development') { | ||
// const { worker } = require('./mocks/browser'); | ||
// worker.start({ quiet: true }); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호.. 북마크 작업할 때 null일수도 있다는걸 제가 간과한거 같은데 이 부분 수정해야겠군요..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구우웃~!