Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for managing the user defined local authenticators #6172

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Dec 3, 2024

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch from 9f9126d to 7964563 Compare December 3, 2024 05:20
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 87.41722% with 57 lines in your changes missing coverage. Please review.

Project coverage is 40.95%. Comparing base (37745ca) to head (4300b0f).
Report is 77 commits behind head on master.

Files with missing lines Patch % Lines
...on/internal/ApplicationCommonServiceComponent.java 0.00% 20 Missing ⚠️
...ommon/dao/impl/AuthenticatorManagementDAOImpl.java 92.85% 7 Missing and 2 partials ⚠️
...common/dao/impl/AuthenticatorManagementFacade.java 85.45% 7 Missing and 1 partial ⚠️
...ommon/dao/impl/CacheBackedAuthenticatorMgtDAO.java 84.21% 0 Missing and 6 partials ⚠️
.../common/util/AuthenticatorMgtExceptionBuilder.java 90.69% 1 Missing and 3 partials ⚠️
...UserDefinedAuthenticatorEndpointConfigManager.java 95.77% 3 Missing ⚠️
...cation/common/ApplicationAuthenticatorService.java 94.44% 1 Missing and 1 partial ⚠️
...lication/common/cache/AuthenticatorCacheEntry.java 66.66% 2 Missing ⚠️
...pplication/common/cache/AuthenticatorCacheKey.java 75.00% 1 Missing and 1 partial ⚠️
...eption/AuthenticatorMgtServerRuntimeException.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6172      +/-   ##
============================================
- Coverage     45.33%   40.95%   -4.38%     
- Complexity    13832    15719    +1887     
============================================
  Files          1614     1812     +198     
  Lines         99700   126242   +26542     
  Branches      16833    22331    +5498     
============================================
+ Hits          45196    51705    +6509     
- Misses        47860    66931   +19071     
- Partials       6644     7606     +962     
Flag Coverage Δ
unit 28.13% <87.41%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch 8 times, most recently from 9acc1e1 to be4aa7a Compare December 3, 2024 12:45
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch 8 times, most recently from 18bfd6c to 7e187ae Compare December 13, 2024 04:20
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch from 7e187ae to 4300b0f Compare December 13, 2024 04:33
Copy link

sonarcloud bot commented Dec 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants